Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340723005: [DevTools] Remove unnecessary emulation checkboxes and simplify UX. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Remove unnecessary emulation checkboxes and simplify UX. BUG=327641 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176423

Patch Set 1 #

Patch Set 2 : test, removed unused ua list #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -488 lines) Patch
M LayoutTests/http/tests/inspector-enabled/open-with-emulation-enabled.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/ResponsiveDesignView.js View 1 2 8 chunks +23 lines, -38 lines 0 comments Download
M Source/devtools/front_end/common/Settings.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 9 chunks +35 lines, -211 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 2 chunks +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/overrides.css View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/responsiveDesignView.css View 1 2 8 chunks +37 lines, -28 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 25 chunks +72 lines, -158 lines 0 comments Download
M Source/devtools/front_end/ui/SettingsUI.js View 3 chunks +8 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-18 12:13:25 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-18 12:17:55 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-18 12:30:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/340723005/10010
6 years, 6 months ago (2014-06-18 12:30:35 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 14:33:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18658)
6 years, 6 months ago (2014-06-18 14:33:12 UTC) #6
dgozman
6 years, 6 months ago (2014-06-18 14:37:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r176423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698