Issue 340713002: chrome.serial: [POSIX] Queue *Completed() callback in Cancel*Impl()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340713002: chrome.serial: [POSIX] Queue Completed() callback in CancelImpl() (Closed)

Created:
6 years, 6 months ago by hacker64

Modified:
6 years, 6 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

chrome.serial: [POSIX] Queue *Completed() callback in Cancel*Impl() On Mac, Linux and Chrome OS, when a call is made to SerialIoHandler::CancelRead() or SerialIoHandler::CancelWrite(), no callback to SerialIoHandler:ReadCompleted() or SerialIoHandler::WriteCompleted() is triggered in the underlying implementation, as it is on Windows. This causes the cleanup code in SerialConnection::OnAsync*Complete() to never be executed. To fix the behaviour, call SerialIoHandler::Queue*Completed() directly from SerialIoHandlerPosix::Cancel*Impl(). The only code changes are in serial_io_handler_posix.cc, so there should be no effect on Windows. BUG=383221 R=rockot@chromium.org TEST=Toggle chrome.serial.setPaused() true then false; more detail and a link to a test app is provided in crbug.com/383221 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278130

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/extensions/api/serial/serial_io_handler_posix.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download