Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Issue 340703004: Check before setting initial border image styles (Closed)

Created:
6 years, 6 months ago by pdr.
Modified:
6 years, 6 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Check before setting initial border image styles Border-image and its friend mask-box-image are shorthands that expand out into 4 css properties[1]. When setting the initial values for these we would blindly create a new NinePieceBorderImage which is large and contains non-trivial destructors. This patch first checks whether the current value is already equal to the initial value before setting. [1] https://developer.mozilla.org/en-US/docs/Web/CSS/border-image Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176492

Patch Set 1 #

Patch Set 2 : Fix mask slice, cleanup static helpers #

Patch Set 3 : Fix mask slice fill #

Patch Set 4 : Reorder for readability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 2 3 1 chunk +51 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
Just FYI
6 years, 6 months ago (2014-06-18 20:46:32 UTC) #1
esprehn
lgtm, this seems totally reasonable.
6 years, 6 months ago (2014-06-18 20:54:37 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-19 04:37:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/340703004/60001
6 years, 6 months ago (2014-06-19 04:38:27 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 06:33:24 UTC) #5
Message was sent while issue was closed.
Change committed as 176492

Powered by Google App Engine
This is Rietveld 408576698