Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: tests/compiler/dart2js/message_kind_helper.dart

Issue 340703003: Prevent double reporting on hex, strings, and multiline comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments and comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/message_kind_helper.dart
diff --git a/tests/compiler/dart2js/message_kind_helper.dart b/tests/compiler/dart2js/message_kind_helper.dart
index 81b6824f8a3f522ec0297c60fece59d28d4c521d..dfadfb2b3cef23fd32fb2ae2bfeec2939cfffc13 100644
--- a/tests/compiler/dart2js/message_kind_helper.dart
+++ b/tests/compiler/dart2js/message_kind_helper.dart
@@ -39,11 +39,6 @@ final Set<MessageKind> kindsWithExtraMessages = new Set<MessageKind>.from([
MessageKind.UNIMPLEMENTED_METHOD_ONE,
MessageKind.VAR_FUNCTION_TYPE_PARAMETER,
MessageKind.VOID_NOT_ALLOWED,
-
- MessageKind.HEX_DIGIT_EXPECTED, // http://dartbug.com/18574
- MessageKind.UNMATCHED_TOKEN, // http://dartbug.com/18574
- MessageKind.UNTERMINATED_COMMENT, // http://dartbug.com/18574
- MessageKind.UNTERMINATED_STRING, // http://dartbug.com/18574
]);
/// Most messages can be tested without causing a fatal error. Add an exception
@@ -60,7 +55,6 @@ final Set<MessageKind> kindsWithPendingClasses = new Set<MessageKind>.from([
/// stop before analyzing all input, and it isn't safe to reuse it.
final Set<MessageKind> kindsWithFatalErrors = new Set<MessageKind>.from([
// If you add something here, please file a *new* bug report.
- MessageKind.HEX_DIGIT_EXPECTED,
MessageKind.UNMATCHED_TOKEN,
MessageKind.UNTERMINATED_STRING,
]);
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/scanner.dart ('k') | tests/language/bad_raw_string_negative_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698