sdk/lib/_internal/compiler/implementation/scanner/parser.dart - Issue 340703003: Prevent double reporting on hex, strings, and multiline comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/parser.dart

Issue 340703003: Prevent double reporting on hex, strings, and multiline comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comments and comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/listener.dart ('k') | sdk/lib/_internal/compiler/implementation/scanner/scanner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/scanner/parser.dart

diff --git a/sdk/lib/_internal/compiler/implementation/scanner/parser.dart b/sdk/lib/_internal/compiler/implementation/scanner/parser.dart

index e6163a9fe8e287a38b1cc3c458312a6ecdb92c9b..33fbfeb982fc34067e43f7b5438407afd48eea68 100644

--- a/sdk/lib/_internal/compiler/implementation/scanner/parser.dart

+++ b/sdk/lib/_internal/compiler/implementation/scanner/parser.dart

@@ -656,7 +656,7 @@ class Parser {

Link<Token> identifiers = findMemberName(token);

if (identifiers.isEmpty) {

- return listener.unexpected(start);

+ return listener.expectedDeclaration(start);

}

Token name = identifiers.head;

identifiers = identifiers.tail;

@@ -905,7 +905,7 @@ class Parser {

}

token = token.next;

}

- return listener.expectedDeclaration(start);

+ return const Link<Token>();

}

Token parseVariableInitializerOpt(Token token) {

@@ -1076,7 +1076,7 @@ class Parser {

Link<Token> identifiers = findMemberName(token);

if (identifiers.isEmpty) {

- return listener.unexpected(start);

+ return listener.expectedDeclaration(start);

}

Token name = identifiers.head;

Token afterName = name.next;