Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 340583002: Use all_dependent_settings to apply libc++ flags. (Closed)

Created:
6 years, 6 months ago by earthdok
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use all_dependent_settings to apply libc++ flags. With direct_dependent_settings, the flags fail to propagate to certain targets. BUG=366570 R=glider@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libc++/libc++.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
earthdok
ptal I must admit I no longer understand the issue that led to this. But ...
6 years, 6 months ago (2014-06-17 18:21:10 UTC) #1
Alexander Potapenko
On 2014/06/17 18:21:10, earthdok wrote: > ptal > > I must admit I no longer ...
6 years, 6 months ago (2014-06-18 13:52:31 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 6 months ago (2014-06-18 13:56:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/340583002/1
6 years, 6 months ago (2014-06-18 13:57:15 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 15:33:50 UTC) #5
Message was sent while issue was closed.
Change committed as 278090

Powered by Google App Engine
This is Rietveld 408576698