Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2116)

Issue 340573005: Remove two unused logging::LogMessage constructors. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove two unused logging::LogMessage constructors. (We could probably also get rid of a third one, namely the one used by CHECK_EQ, etc. But I'd do that separately.) R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -33 lines) Patch
M base/logging.h View 1 chunk +4 lines, -22 lines 0 comments Download
M base/logging.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 6 months ago (2014-06-18 01:27:52 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-18 05:37:50 UTC) #2
viettrungluu
6 years, 6 months ago (2014-06-18 15:04:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r278066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698