Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340563002: Remove duplicate WebScopedUserGesture.cpp entry from web.gyp (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, brettw
Project:
blink
Visibility:
Public.

Description

Remove duplicate WebScopedUserGesture.cpp entry from web.gyp R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
In the GN build, this produces multiple ninja rules that output the same object file ...
6 years, 6 months ago (2014-06-17 18:00:39 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-17 18:01:12 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-17 18:01:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/340563002/1
6 years, 6 months ago (2014-06-17 18:02:19 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 19:51:10 UTC) #5
Message was sent while issue was closed. 
Change committed as 176350

Powered by Google App Engine
This is Rietveld 408576698