Stop depending on TemplateURLService from DefaultSearchManager

Stop depending on TemplateURLService from DefaultSearchManager

TemplateURLService::fallback_search_engines_disabled only affects the behavior of DefaultSearchManager.
Move it to DefaultSearchManager.

BUG=371535
TEST=git cl try

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278038

[hashimoto, 2014-06-17 23:32:48]

Peter, could you review this?

[Peter Kasting, 2014-06-18 00:01:04]

LGTM

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/default_search_manager.cc (right):

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/default_search_manager.cc:30: bool
g_fallback_search_engines_disabled  = false;
Nit: Extra space

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/default_search_manager.h (right):

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/default_search_manager.h:107: // Disables the
pre-populated TemplateURLs for testing purposes.
Nit: This comment doesn't seem very accurate or helpful; how about

Testing code can call this with |disabled| set to true to cause
GetDefaultSearchEngine() to return NULL instead of |fallback_default_search_| in
cases where the DSE source is FROM_FALLBACK.

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/default_search_manager.h:108: static void
SetFallbackSearchEnginesDisabledForTesting(bool disabled);
Nit: I would put this up with the other static methods.

[hashimoto, 2014-06-18 00:08:38]

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/default_search_manager.cc (right):

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/default_search_manager.cc:30: bool
g_fallback_search_engines_disabled  = false;
On 2014/06/18 00:01:04, Peter Kasting wrote:
> Nit: Extra space

Done.

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/default_search_manager.h (right):

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/default_search_manager.h:107: // Disables the
pre-populated TemplateURLs for testing purposes.
On 2014/06/18 00:01:04, Peter Kasting wrote:
> Nit: This comment doesn't seem very accurate or helpful; how about
> 
> Testing code can call this with |disabled| set to true to cause
> GetDefaultSearchEngine() to return NULL instead of |fallback_default_search_|
in
> cases where the DSE source is FROM_FALLBACK.

Done.

https://codereview.chromium.org/340553005/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/default_search_manager.h:108: static void
SetFallbackSearchEnginesDisabledForTesting(bool disabled);
On 2014/06/18 00:01:04, Peter Kasting wrote:
> Nit: I would put this up with the other static methods.

Done.

[hashimoto, 2014-06-18 00:08:42]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-06-18 00:10:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/340553005/40001

[commit-bot: I haz the power, 2014-06-18 11:48:04]

Change committed as 278038