LayoutTests/media/media-controller-effective-playback-rate.html - Issue 340553004: Always notify the MediaPlayer of any seek.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/media-controller-effective-playback-rate.html

Issue 340553004: Always notify the MediaPlayer of any seek. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Test effective playback rate with a MediaController.</title>	4 <title>Test effective playback rate with a MediaController.</title>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script src="video-test.js"></script>	6 <script src="video-test.js"></script>

7 <script>	7 <script>

8 var start = function()	8 var start = function()

9 {	9 {

10 findMediaElement();	10 findMediaElement();

11 video.src = findMediaFile("video", "content/test");	11 video.src = findMediaFile("video", "content/test");

12	12

13 // Set the rate on the media element so playback won't move forw ard.	13 // Set the rate on the media element so playback won't move forw ard.

14 video.playbackRate = 0;	14 video.playbackRate = 0;

15	15

16 waitForEvent("canplay",canplay);	16 waitForEventOnce("canplay",canplay);
	acolwell GONE FROM CHROMIUM 2014/06/17 21:52:36 This change and the other one like it is needed be This change and the other one like it is needed because this test assumes that canplay will only fire once. Part of the media controller's "bringing the element up to speed" algorithm issues a seek on the element in response to play(). Now that the media engine is being notified of all seeks, a readyState transition to HAVE_METADATA can occur which opens up the possibility for another "canplay" event to fire. This change simply changes to test to reflect the original intent which was "on the first canplay event call canplay".
17 };	17 };

18	18

19 var canplay = function()	19 var canplay = function()

20 {	20 {

21 video.controller = new MediaController();	21 video.controller = new MediaController();

22	22

23 // Verify the controller playback rate is 1. This	23 // Verify the controller playback rate is 1. This

24 // means the "effective playback rate" is 1 even though	24 // means the "effective playback rate" is 1 even though

25 // the HTMLMediaElement's playbackRate attribute is 0.	25 // the HTMLMediaElement's playbackRate attribute is 0.

26 testExpected("video.controller.playbackRate", 1);	26 testExpected("video.controller.playbackRate", 1);

(...skipping 12 matching lines...) Expand all Loading...
39 var timeupdate = function() {	39 var timeupdate = function() {

40 testExpected("video.currentTime", 0, "!=");	40 testExpected("video.currentTime", 0, "!=");

41 endTest();	41 endTest();

42 };	42 };

43 </script>	43 </script>

44 </head>	44 </head>

45 <body onload="start()">	45 <body onload="start()">

46 <video></video>	46 <video></video>

47 </body>	47 </body>

48 </html>	48 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/media-controller-playbackrate.html » ('j') | LayoutTests/media/video-seek-to-current-position.html » ('J')