Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340553003: Update actions.xml for safe browsing extended reporting (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, stevenjb
Project:
chromium
Visibility:
Public.

Description

Update actions.xml for safe browsing extended reporting This updates actions.xml to account for the new extended reporting option. BUG=383866 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277803

Patch Set 1 #

Total comments: 2

Patch Set 2 : No parens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M tools/metrics/actions/actions.xml View 1 1 chunk +20 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
felt
PTAL? quick update for actions.xml. Forgot to do it as part of 336673002.
6 years, 6 months ago (2014-06-17 17:28:38 UTC) #1
Ilya Sherman
LGTM % a nit. Thanks, Adrienne. https://codereview.chromium.org/340553003/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/340553003/diff/1/tools/metrics/actions/actions.xml#newcode8754 tools/metrics/actions/actions.xml:8754: <description>Safe Browsing Extended ...
6 years, 6 months ago (2014-06-17 17:36:23 UTC) #2
felt
https://codereview.chromium.org/340553003/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/340553003/diff/1/tools/metrics/actions/actions.xml#newcode8754 tools/metrics/actions/actions.xml:8754: <description>Safe Browsing Extended Reporting (disabled)</description> On 2014/06/17 17:36:23, Ilya ...
6 years, 6 months ago (2014-06-17 17:45:22 UTC) #3
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-17 17:45:25 UTC) #4
felt
The CQ bit was unchecked by felt@chromium.org
6 years, 6 months ago (2014-06-17 17:45:37 UTC) #5
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-17 17:45:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/340553003/20001
6 years, 6 months ago (2014-06-17 17:47:37 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:56:24 UTC) #8
Message was sent while issue was closed. 
Change committed as 277803

Powered by Google App Engine
This is Rietveld 408576698