views: Support longer tooltips.

views: Support longer tooltips.

Increase the maximum tooltip length from 1024 characters to
2048. Increase the maximum dimensions for tooltips. Delete
the line-wrapping code and just use a views::Label instead.

BUG=370226

[sky, 2014-06-18 03:20:07]

https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
File ui/views/corewm/tooltip_aura.cc (right):

https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
ui/views/corewm/tooltip_aura.cc:68: void TooltipAura::TrimTooltipToFit(const
gfx::FontList& font_list,
I think we should convert this to use views::Label. It does all the wrapping and
should be a lot simpler.

https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
ui/views/corewm/tooltip_aura.cc:161: return gfx::Size(display_bounds.width() * 3
/ 4,
I'm inclined to give the tooltip the full width. WDYT?

[Daniel Erat, 2014-06-18 04:37:11]

https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
File ui/views/corewm/tooltip_aura.cc (right):

https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
ui/views/corewm/tooltip_aura.cc:68: void TooltipAura::TrimTooltipToFit(const
gfx::FontList& font_list,
On 2014/06/18 03:20:07, sky wrote:
> I think we should convert this to use views::Label. It does all the wrapping
and
> should be a lot simpler.

i don't know the history here, but i believe that this text already goes into a
views::Label. presumably Label doesn't (or didn't?) do everything that's needed.
varun?

[Daniel Erat, 2014-06-22 04:27:56]

On 2014/06/18 04:37:11, Daniel Erat wrote:
>
https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
> File ui/views/corewm/tooltip_aura.cc (right):
> 
>
https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
> ui/views/corewm/tooltip_aura.cc:68: void TooltipAura::TrimTooltipToFit(const
> gfx::FontList& font_list,
> On 2014/06/18 03:20:07, sky wrote:
> > I think we should convert this to use views::Label. It does all the wrapping
> and
> > should be a lot simpler.
> 
> i don't know the history here, but i believe that this text already goes into
a
> views::Label. presumably Label doesn't (or didn't?) do everything that's
needed.
> varun?

varun: ping

[varunjain, 2014-06-22 20:00:31]

https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
File ui/views/corewm/tooltip_aura.cc (right):

https://codereview.chromium.org/340543004/diff/40001/ui/views/corewm/tooltip_...
ui/views/corewm/tooltip_aura.cc:68: void TooltipAura::TrimTooltipToFit(const
gfx::FontList& font_list,
On 2014/06/18 04:37:11, Daniel Erat wrote:
> On 2014/06/18 03:20:07, sky wrote:
> > I think we should convert this to use views::Label. It does all the wrapping
> and
> > should be a lot simpler.
> 
> i don't know the history here, but i believe that this text already goes into
a
> views::Label. presumably Label doesn't (or didn't?) do everything that's
needed.
> varun?

Sorry I do not remember why label was not used directly. I have not worked on
this for along time now. I do remember that this function was copied from the
really old tooltip_manager so it might not be required. Other than that I have
no recollection of what/why this is.

[Daniel Erat, 2014-07-30 23:03:40]

i've updated this to use views::Label instead. i think that there's a bug where
Label::GetTextBounds() calls GetAvailableRect() before it's been initialized
properly, resulting the label getting a 100x[big-number] size the first time
it's shown and then something reasonable later. mike's
https://codereview.chromium.org/413823002/ appears to fix this but changes
enough other stuff that it's a bit risky. i don't think there's any rush on
getting this fix in since the bug has been around forever, but please take
another look when you get the chance so this can go in after mike's change is
in.

[sky, 2014-07-31 15:11:48]

LGTM