Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340533002: hide SkBitmap::Config entirely (behind a flag) (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

hide SkBitmap::Config entirely (behind a flag) patch from issue 339463002 TBR= I think the NoGPU failure is unrelated, so ignoring NOTRY=True Committed: https://skia.googlesource.com/skia/+/c3b3266b7db2f1a41d41ecac010c766b7ad8eebc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -49 lines) Patch
M gm/bitmapfilters.cpp View 3 chunks +3 lines, -11 lines 0 comments Download
M gyp/SampleApp.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M gyp/gm.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmap.h View 3 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkImageDecoder.h View 3 chunks +5 lines, -1 line 0 comments Download
M include/gpu/SkGr.h View 1 chunk +2 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 3 chunks +2 lines, -14 lines 0 comments Download
M samplecode/SampleFilter.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M src/animator/SkDrawBitmap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/image/SkImagePriv.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 4 chunks +8 lines, -0 lines 0 comments Download
M tests/KtxTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ktx/ktx.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M tools/skpdiff/SkDifferentPixelsMetric_cpu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-17 14:32:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/340533002/1
6 years, 6 months ago (2014-06-17 14:32:50 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 15:00:41 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/347)
6 years, 6 months ago (2014-06-17 15:00:42 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-17 15:37:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/340533002/1
6 years, 6 months ago (2014-06-17 15:38:21 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 15:38:36 UTC) #7
Message was sent while issue was closed. 
Change committed as c3b3266b7db2f1a41d41ecac010c766b7ad8eebc

Powered by Google App Engine
This is Rietveld 408576698