Linux sandbox: add sandbox_linux_unittests.isolate

Linux sandbox: add sandbox_linux_unittests.isolate

BUG=384514
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277867

[jln (very slow on Chromium), 2014-06-17 20:36:53]

Nodir, could you please take a look?

[nodir, 2014-06-17 20:38:23]

On 2014/06/17 20:36:53, jln wrote:
> Nodir, could you please take a look?

+vadimsh, as the primary isolated engineer

[Vadim Sh., 2014-06-17 20:42:15]

+maruel, even more primary isolate engineer :)

but lgtm, assuming sandbox_linux_unittests executable is not using any data
files from src/ (otherwise they need to be specified in *.isolate).

[M-A Ruel, 2014-06-17 20:45:27]

On 2014/06/17 20:42:15, Vadim Sh. wrote:
> +maruel, even more primary isolate engineer :)
>
> but lgtm, assuming sandbox_linux_unittests executable is not using any data
> files from src/ (otherwise they need to be specified in *.isolate).

lgtm; Vadim is a totally appropriate reviewer.

[jln (very slow on Chromium), 2014-06-17 20:55:32]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-06-17 20:57:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jln@chromium.org/340523006/1

[commit-bot: I haz the power, 2014-06-17 21:23:16]

Change committed as 277867

[jln (very slow on Chromium), 2014-06-17 21:46:17]

A revert of this CL has been created in
https://codereview.chromium.org/339183007/ by jln@chromium.org.

The reason for reverting is: Breaking linux_chromium_clang_dbg 

[7609/24970 | 449.637] SOLINK lib/libmojo_launcher.so
FAILED: cd ../../sandbox; python ../tools/isolate_driver.py check --isolated
"../out/Debug/sandbox_linux_unittests.isolated" --isolate
"linux/sandbox_linux_unittests.isolate" --path-variable DEPTH .. --path-variable
PRODUCT_DIR "../out/Debug " --extra-variable "version_full=37.0.2056.0"
--config-variable "OS=linux" --config-variable "chromeos=0" --config-variable
"component=shared_library" --config-variable "internal_gles2_conform_tests=0"
--config-variable "icu_use_data_file_flag=1" --config-variable
"libpeer_target_type=static_library" --config-variable "use_openssl=0"
--ignore_broken_items
Traceback (most recent call last):
  File "../tools/isolate_driver.py", line 279, in <module>
    sys.exit(main())
  File "../tools/isolate_driver.py", line 269, in main
    create_wrapper(args, isolate, isolated)
  File "../tools/isolate_driver.py", line 194, in create_wrapper
    assert os.path.basename(isolate) == isolate, isolate
AssertionError: linux/sandbox_linux_unittests.isolate
ninja: build stopped: subcommand failed.
.

[jln (very slow on Chromium), 2014-06-17 21:50:53]

maruel: could you advise what I should do about this?

You wrote:

  # The code assumes the .isolate file is always specified path-less in cwd. Fix
  # if this assumption doesn't hold true.
  assert os.path.basename(isolate) == isolate, isolate

[jln (very slow on Chromium), 2014-06-17 22:03:46]

On 2014/06/17 21:50:53, jln wrote:
> maruel: could you advise what I should do about this?
> 
> You wrote:
> 
>   # The code assumes the .isolate file is always specified path-less in cwd.
Fix
>   # if this assumption doesn't hold true.
>   assert os.path.basename(isolate) == isolate, isolate

I've done so in https://chromiumcodereview.appspot.com/341623003/, let's discuss
there.