Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 340513004: Minor Refactor in RenderFlexbox (Closed)

Created:
6 years, 6 months ago by harpreet.sk
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Minor Refactor in RenderFlexbox This is a minor refactoring which moves the case of calculation of cross-size of flex line for single line flex-container from RenderFlexibleBox::repositionLogicalHeightDependentFlexItems to RenderFlexibleBox::alignFlexLines which is more appropriate and saves us from doing unnecessary work. The old code was doing align-content for a single line, then reposition everything when aligning children. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M Source/core/rendering/RenderFlexibleBox.cpp View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
harpreet.sk
Minor change. PTAL..
6 years, 6 months ago (2014-06-17 12:38:42 UTC) #1
tony
This looks correct to me. I would mention in the change description that this saves ...
6 years, 6 months ago (2014-06-17 16:11:13 UTC) #2
cbiesinger
lgtm but I'm not an owner, so tony/ojan will have to review or rubberstamp this.
6 years, 6 months ago (2014-06-17 22:56:15 UTC) #3
tony
On 2014/06/17 22:56:15, cbiesinger wrote: > lgtm > > but I'm not an owner, so ...
6 years, 6 months ago (2014-06-17 22:59:23 UTC) #4
leviw_travelin_and_unemployed
I am. rslgtm.
6 years, 6 months ago (2014-06-17 23:23:57 UTC) #5
harpreet.sk
The CQ bit was checked by harpreet.sk@samsung.com
6 years, 6 months ago (2014-06-18 05:13:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/340513004/1
6 years, 6 months ago (2014-06-18 05:13:40 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 06:54:03 UTC) #8
Message was sent while issue was closed.
Change committed as 176399

Powered by Google App Engine
This is Rietveld 408576698