Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: Source/devtools/front_end/settings/SettingsScreen.js

Issue 340513003: DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased patch Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/settings/SettingsScreen.js
diff --git a/Source/devtools/front_end/settings/SettingsScreen.js b/Source/devtools/front_end/settings/SettingsScreen.js
index e0c558f3b2c7d75caf83cec7a7001c7edbd7202d..7beb3b8eb9fe35f6916bd5de2985422e46738e04 100644
--- a/Source/devtools/front_end/settings/SettingsScreen.js
+++ b/Source/devtools/front_end/settings/SettingsScreen.js
@@ -221,7 +221,7 @@ WebInspector.GenericSettingsTab = function()
var restoreDefaults = this._appendSection().createChild("input", "settings-tab-text-button");
restoreDefaults.type = "button";
restoreDefaults.value = WebInspector.UIString("Restore defaults and reload");
- restoreDefaults.addEventListener("click", restoreAndReload);
+ restoreDefaults.addEventListener("click", restoreAndReload, false);
function restoreAndReload()
{
@@ -383,12 +383,12 @@ WebInspector.WorkspaceSettingsTab = function()
var addFileSystemButton = this._addFileSystemRowElement.createChild("input", "settings-tab-text-button");
addFileSystemButton.type = "button";
addFileSystemButton.value = WebInspector.UIString("Add folder\u2026");
- addFileSystemButton.addEventListener("click", this._addFileSystemClicked.bind(this));
+ addFileSystemButton.addEventListener("click", this._addFileSystemClicked.bind(this), false);
this._editFileSystemButton = this._addFileSystemRowElement.createChild("input", "settings-tab-text-button");
this._editFileSystemButton.type = "button";
this._editFileSystemButton.value = WebInspector.UIString("Edit\u2026");
- this._editFileSystemButton.addEventListener("click", this._editFileSystemClicked.bind(this));
+ this._editFileSystemButton.addEventListener("click", this._editFileSystemClicked.bind(this), false);
this._updateEditFileSystemButtonState();
this._reset();
@@ -451,10 +451,7 @@ WebInspector.WorkspaceSettingsTab.prototype = {
this._editFileSystem(id);
},
- /**
- * @param {!WebInspector.Event=} event
- */
- _editFileSystemClicked: function(event)
+ _editFileSystemClicked: function()
{
this._editFileSystem(this._selectedFileSystemPath());
},
@@ -805,7 +802,7 @@ WebInspector.SettingsList.prototype = {
/**
* @param {?string} id
- * @param {!Event=} event
+ * @param {?Event=} event
*/
_onDoubleClick: function(id, event)
{
@@ -814,7 +811,7 @@ WebInspector.SettingsList.prototype = {
/**
* @param {?string} id
- * @param {!Event=} event
+ * @param {?Event=} event
*/
selectItem: function(id, event)
{
@@ -896,10 +893,10 @@ WebInspector.EditableSettingsList.prototype = {
columnElement.classList.add("settings-list-column-" + columnId);
var placeholder = (columnId === "url") ? WebInspector.UIString("URL prefix") : WebInspector.UIString("Folder path");
if (itemId === null) {
- var inputElement = columnElement.createChild("input", "list-column-editor");
+ var inputElement = /** @type {!HTMLInputElement} */ (columnElement.createChild("input", "list-column-editor"));
inputElement.placeholder = placeholder;
- inputElement.addEventListener("blur", this._onAddMappingInputBlur.bind(this));
- inputElement.addEventListener("input", this._validateEdit.bind(this, itemId));
+ inputElement.addEventListener("blur", this._onAddMappingInputBlur.bind(this), false);
+ inputElement.addEventListener("input", this._validateEdit.bind(this, itemId), false);
this._addInputElements[columnId] = inputElement;
return;
}
@@ -912,16 +909,16 @@ WebInspector.EditableSettingsList.prototype = {
var value = this._valuesProvider(itemId, columnId);
- var textElement = columnElement.createChild("span", "list-column-text");
+ var textElement = /** @type {!HTMLSpanElement} */ (columnElement.createChild("span", "list-column-text"));
textElement.textContent = value;
textElement.title = value;
columnElement.addEventListener("click", rowClicked.bind(this), false);
this._textElements[itemId][columnId] = textElement;
- var inputElement = columnElement.createChild("input", "list-column-editor");
+ var inputElement = /** @type {!HTMLInputElement} */ (columnElement.createChild("input", "list-column-editor"));
inputElement.value = value;
- inputElement.addEventListener("blur", this._editMappingBlur.bind(this, itemId));
- inputElement.addEventListener("input", this._validateEdit.bind(this, itemId));
+ inputElement.addEventListener("blur", this._editMappingBlur.bind(this, itemId), false);
+ inputElement.addEventListener("input", this._validateEdit.bind(this, itemId), false);
columnElement.inputElement = inputElement;
this._editInputElements[itemId][columnId] = inputElement;
@@ -1011,7 +1008,7 @@ WebInspector.EditableSettingsList.prototype = {
/**
* @param {string} itemId
- * @param {!Event} event
+ * @param {?Event} event
*/
_editMappingBlur: function(itemId, event)
{
« no previous file with comments | « Source/devtools/front_end/search/SourcesSearchScope.js ('k') | Source/devtools/front_end/source_frame/ResourceView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698