Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 340513003: DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased patch Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | Source/devtools/front_end/network/RequestTimingView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 56bbe5cb12e013360906b1dba076f0b082a7b648..84ceac2db6ff57f05f7a2b2115a37f29d893ec66 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -2838,6 +2838,11 @@ WebInspector.NetworkDataGridNode.prototype = {
__proto__: WebInspector.DataGridNode.prototype
}
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.NameComparator = function(a, b)
{
var aFileName = a._request.name();
@@ -2849,6 +2854,11 @@ WebInspector.NetworkDataGridNode.NameComparator = function(a, b)
return 0;
}
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.RemoteAddressComparator = function(a, b)
{
var aRemoteAddress = a._request.remoteAddress();
@@ -2860,6 +2870,11 @@ WebInspector.NetworkDataGridNode.RemoteAddressComparator = function(a, b)
return 0;
}
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.SizeComparator = function(a, b)
{
if (b._request.cached && !a._request.cached)
@@ -2870,6 +2885,11 @@ WebInspector.NetworkDataGridNode.SizeComparator = function(a, b)
return a._request.transferSize - b._request.transferSize;
}
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.InitiatorComparator = function(a, b)
{
var aInitiator = a._request.initiatorInfo();
@@ -2903,6 +2923,11 @@ WebInspector.NetworkDataGridNode.InitiatorComparator = function(a, b)
return 0;
}
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.RequestCookiesCountComparator = function(a, b)
{
var aScore = a._request.requestCookies ? a._request.requestCookies.length : 0;
@@ -2910,6 +2935,11 @@ WebInspector.NetworkDataGridNode.RequestCookiesCountComparator = function(a, b)
return aScore - bScore;
}
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.ResponseCookiesCountComparator = function(a, b)
{
var aScore = a._request.responseCookies ? a._request.responseCookies.length : 0;
@@ -2917,6 +2947,13 @@ WebInspector.NetworkDataGridNode.ResponseCookiesCountComparator = function(a, b)
return aScore - bScore;
}
+/**
+ * @param {string} propertyName
+ * @param {boolean} revert
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyName, revert, a, b)
{
var aValue = a._request[propertyName];
« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | Source/devtools/front_end/network/RequestTimingView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698