Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: Source/devtools/front_end/components/FlameChart.js

Issue 340513003: DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/FlameChart.js
diff --git a/Source/devtools/front_end/components/FlameChart.js b/Source/devtools/front_end/components/FlameChart.js
index 32cd82d9f2dd0925a61837bc55dd4a323b92a575..f818b5b8e1858824a0d782c3ede5ac1344785dac 100644
--- a/Source/devtools/front_end/components/FlameChart.js
+++ b/Source/devtools/front_end/components/FlameChart.js
@@ -58,7 +58,7 @@ WebInspector.FlameChart = function(dataProvider, flameChartDelegate, isTopDown)
this._calculator = new WebInspector.FlameChart.Calculator();
this._canvas = this.element.createChild("canvas");
- this._canvas.addEventListener("mousemove", this._onMouseMove.bind(this));
+ this._canvas.addEventListener("mousemove", this._onMouseMove.bind(this), false);
this._canvas.addEventListener("mousewheel", this._onMouseWheel.bind(this), false);
this._canvas.addEventListener("click", this._onClick.bind(this), false);
WebInspector.installDragHandle(this._canvas, this._startCanvasDragging.bind(this), this._canvasDragging.bind(this), this._endCanvasDragging.bind(this), "move", null);
@@ -165,7 +165,7 @@ WebInspector.FlameChartDataProvider.prototype = {
/**
* @param {number} entryIndex
- * @return {!string}
+ * @return {string}
*/
entryColor: function(entryIndex) { },
@@ -190,7 +190,7 @@ WebInspector.FlameChartDataProvider.prototype = {
/**
* @param {number} entryIndex
- * @return {!string}
+ * @return {string}
*/
textColor: function(entryIndex) { },
@@ -449,7 +449,7 @@ WebInspector.FlameChart.prototype = {
},
/**
- * @param {?MouseEvent} event
+ * @param {?Event} event
*/
_onMouseMove: function(event)
{
@@ -494,7 +494,7 @@ WebInspector.FlameChart.prototype = {
},
/**
- * @param {?MouseEvent} e
+ * @param {?Event} e
*/
_onMouseWheel: function(e)
{

Powered by Google App Engine
This is Rietveld 408576698