Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: Source/devtools/front_end/ScreencastView.js

Issue 340513003: DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ScreencastView.js
diff --git a/Source/devtools/front_end/ScreencastView.js b/Source/devtools/front_end/ScreencastView.js
index 7a10a5a352037bec3203a1b4c4f74812e36d50d7..cc5724da6fa00580b793f1073ca08e02ffc8fc27 100644
--- a/Source/devtools/front_end/ScreencastView.js
+++ b/Source/devtools/front_end/ScreencastView.js
@@ -249,7 +249,7 @@ WebInspector.ScreencastView.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
yurys 2014/06/17 11:32:28 When can event be null?
apavlov 2014/06/17 12:46:03 This is how it is specified in the compiler own ex
*/
_handleMouseEvent: function(event)
{
@@ -288,7 +288,7 @@ WebInspector.ScreencastView.prototype = {
},
/**
- * @param {!KeyboardEvent} event
+ * @param {?Event} event
*/
_handleKeyEvent: function(event)
{
@@ -297,7 +297,7 @@ WebInspector.ScreencastView.prototype = {
return;
}
- var shortcutKey = WebInspector.KeyboardShortcut.makeKeyFromEvent(event);
+ var shortcutKey = WebInspector.KeyboardShortcut.makeKeyFromEvent(/** @type {!KeyboardEvent} */ (event));
var handler = this._shortcuts[shortcutKey];
if (handler && handler(event)) {
event.consume();
@@ -320,7 +320,7 @@ WebInspector.ScreencastView.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
*/
_handleContextMenuEvent: function(event)
{
@@ -328,7 +328,7 @@ WebInspector.ScreencastView.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
*/
_simulateTouchGestureForMouseEvent: function(event)
{
@@ -489,7 +489,7 @@ WebInspector.ScreencastView.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
* @return {!{x: number, y: number}}
*/
_zoomIntoScreenSpace: function(event)
@@ -502,7 +502,7 @@ WebInspector.ScreencastView.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
* @return {!{x: number, y: number}}
*/
_convertIntoScreenSpace: function(event)
@@ -513,7 +513,7 @@ WebInspector.ScreencastView.prototype = {
},
/**
- * @param {!Event} event
+ * @param {?Event} event
* @return {number}
*/
_modifiersForEvent: function(event)
@@ -943,7 +943,7 @@ WebInspector.ScreencastView.prototype = {
}
/**
- * @param {!HTMLElement} element
+ * @param {!Element} element
* @constructor
*/
WebInspector.ScreencastView.ProgressTracker = function(element) {

Powered by Google App Engine
This is Rietveld 408576698