DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors

Source/devtools/front_end/settings/SettingsScreen.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 203 matching lines @@
  */
 WebInspector.GenericSettingsTab = function()
 {
     WebInspector.SettingsTab.call(this, WebInspector.UIString("General"), "general-tab-content");
 
     this._populateSectionsFromExtensions();
 
     var restoreDefaults = this._appendSection().createChild("input", "settings-tab-text-button");
     restoreDefaults.type = "button";
     restoreDefaults.value = WebInspector.UIString("Restore defaults and reload");
-    restoreDefaults.addEventListener("click", restoreAndReload);
+    restoreDefaults.addEventListener("click", restoreAndReload, false);
 
     function restoreAndReload()
     {
         if (window.localStorage)
             window.localStorage.clear();
         WebInspector.reload();
     }
 }
 
 WebInspector.GenericSettingsTab.prototype = {
@@ skipping 141 matching lines @@
     var folderExcludePatternInput = WebInspector.SettingsUI.createSettingInputField(WebInspector.UIString("Folder exclude pattern"), WebInspector.settings.workspaceFolderExcludePattern, false, 0, "270px", WebInspector.SettingsUI.regexValidator);
     this._commonSection.appendChild(folderExcludePatternInput);
 
     this._fileSystemsSection = this._appendSection(WebInspector.UIString("Folders"));
     this._fileSystemsListContainer = this._fileSystemsSection.createChild("p", "settings-list-container");
 
     this._addFileSystemRowElement = this._fileSystemsSection.createChild("div");
     var addFileSystemButton = this._addFileSystemRowElement.createChild("input", "settings-tab-text-button");
     addFileSystemButton.type = "button";
     addFileSystemButton.value = WebInspector.UIString("Add folder\u2026");
-    addFileSystemButton.addEventListener("click", this._addFileSystemClicked.bind(this));
+    addFileSystemButton.addEventListener("click", this._addFileSystemClicked.bind(this), false);
 
     this._editFileSystemButton = this._addFileSystemRowElement.createChild("input", "settings-tab-text-button");
     this._editFileSystemButton.type = "button";
     this._editFileSystemButton.value = WebInspector.UIString("Edit\u2026");
-    this._editFileSystemButton.addEventListener("click", this._editFileSystemClicked.bind(this));
+    this._editFileSystemButton.addEventListener("click", this._editFileSystemClicked.bind(this), false);
     this._updateEditFileSystemButtonState();
 
     this._reset();
 }
 
 WebInspector.WorkspaceSettingsTab.prototype = {
     wasShown: function()
     {
         WebInspector.SettingsTab.prototype.wasShown.call(this);
         this._reset();
@@ skipping 42 matching lines @@
 
     /**
      * @param {!WebInspector.Event} event
      */
     _fileSystemDoubleClicked: function(event)
     {
         var id = /** @type{?string} */ (event.data);
         this._editFileSystem(id);
     },
 
-    /**
-     * @param {!WebInspector.Event=} event
-     */
-    _editFileSystemClicked: function(event)
+    _editFileSystemClicked: function()
     {
         this._editFileSystem(this._selectedFileSystemPath());
     },
 
     /**
      * @param {?string} id
      */
     _editFileSystem: function(id)
     {
         WebInspector.EditFileSystemDialog.show(WebInspector.inspectorView.element, id);
@@ skipping 330 matching lines @@
      * @param {string} itemId
      * @return {!Element}
      */
     itemForId: function(itemId)
     {
         return this._listItems[itemId];
     },
 
     /**
      * @param {?string} id
-     * @param {!Event=} event
+     * @param {?Event=} event
      */
     _onDoubleClick: function(id, event)
     {
         this.dispatchEventToListeners(WebInspector.SettingsList.Events.DoubleClicked, id);
     },
 
     /**
      * @param {?string} id
-     * @param {!Event=} event
+     * @param {?Event=} event
      */
     selectItem: function(id, event)
     {
         if (typeof this._selectedId !== "undefined") {
             this._listItems[this._selectedId].classList.remove("selected");
         }
 
         this._selectedId = id;
         if (typeof this._selectedId !== "undefined") {
             this._listItems[this._selectedId].classList.add("selected");
@@ skipping 61 matching lines @@
     /**
      * @param {!Element} columnElement
      * @param {string} columnId
      * @param {?string} itemId
      */
     _renderColumn: function(columnElement, columnId, itemId)
     {
         columnElement.classList.add("settings-list-column-" + columnId);
         var placeholder = (columnId === "url") ? WebInspector.UIString("URL prefix") : WebInspector.UIString("Folder path");
         if (itemId === null) {
-            var inputElement = columnElement.createChild("input", "list-column-editor");
+            var inputElement = /** @type {!HTMLInputElement} */ (columnElement.createChild("input", "list-column-editor"));
             inputElement.placeholder = placeholder;
-            inputElement.addEventListener("blur", this._onAddMappingInputBlur.bind(this));
-            inputElement.addEventListener("input", this._validateEdit.bind(this, itemId));
+            inputElement.addEventListener("blur", this._onAddMappingInputBlur.bind(this), false);
+            inputElement.addEventListener("input", this._validateEdit.bind(this, itemId), false);
             this._addInputElements[columnId] = inputElement;
             return;
         }
         var validItemId = itemId;
 
         if (!this._editInputElements[itemId])
             this._editInputElements[itemId] = {};
         if (!this._textElements[itemId])
             this._textElements[itemId] = {};
 
         var value = this._valuesProvider(itemId, columnId);
 
-        var textElement = columnElement.createChild("span", "list-column-text");
+        var textElement = /** @type {!HTMLSpanElement} */ (columnElement.createChild("span", "list-column-text"));
         textElement.textContent = value;
         textElement.title = value;
         columnElement.addEventListener("click", rowClicked.bind(this), false);
         this._textElements[itemId][columnId] = textElement;
 
-        var inputElement = columnElement.createChild("input", "list-column-editor");
+        var inputElement = /** @type {!HTMLInputElement} */ (columnElement.createChild("input", "list-column-editor"));
         inputElement.value = value;
-        inputElement.addEventListener("blur", this._editMappingBlur.bind(this, itemId));
-        inputElement.addEventListener("input", this._validateEdit.bind(this, itemId));
+        inputElement.addEventListener("blur", this._editMappingBlur.bind(this, itemId), false);
+        inputElement.addEventListener("input", this._validateEdit.bind(this, itemId), false);
         columnElement.inputElement = inputElement;
         this._editInputElements[itemId][columnId] = inputElement;
 
         /**
          * @param {?Event} event
          * @this {WebInspector.EditableSettingsList}
          */
         function rowClicked(event)
         {
             if (itemId === this._editingId)
@@ skipping 69 matching lines @@
             if (oldValue !== newValue) {
                 hasChanges = true;
                 break;
             }
         }
         return hasChanges;
     },
 
     /**
      * @param {string} itemId
-     * @param {!Event} event
+     * @param {?Event} event
      */
     _editMappingBlur: function(itemId, event)
     {
         var inputElements = Object.values(this._editInputElements[itemId]);
         if (inputElements.indexOf(event.relatedTarget) !== -1)
             return;
 
         var listItem = this.itemForId(itemId);
         listItem.classList.remove("item-editing");
         delete this._editingId;
@@ skipping 32 matching lines @@
             var columnId = columns[i];
             var inputElement = this._addInputElements[columnId];
             inputElement.value = "";
         }
     },
 
     __proto__: WebInspector.SettingsList.prototype
 }
 
 WebInspector._settingsController = new WebInspector.SettingsController();