Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: Source/devtools/front_end/devices/DevicesView.js

Issue 340513003: DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.VBox} 9 * @extends {WebInspector.VBox}
10 */ 10 */
(...skipping 11 matching lines...) Expand all
22 this._devicesList = this.element.createChild("div"); 22 this._devicesList = this.element.createChild("div");
23 this._devicesList.cellSpacing = 0; 23 this._devicesList.cellSpacing = 0;
24 }; 24 };
25 25
26 WebInspector.DevicesView.MinVersionNewTab = 29; 26 WebInspector.DevicesView.MinVersionNewTab = 29;
27 27
28 28
29 var Adb = {}; 29 var Adb = {};
30 30
31 /** 31 /**
32 * @typedef {{adbBrowserChromeVersion:!string, compatibleVersion: boolean, adbBr owserName: !string, source: !string, adbBrowserVersion: !string}} 32 * @typedef {{id: string, adbBrowserChromeVersion: string, compatibleVersion: bo olean, adbBrowserName: string, source: string, adbBrowserVersion: string}}
33 */ 33 */
34 Adb.Browser; 34 Adb.Browser;
35 35
36 /** 36 /**
37 * @typedef {{adbModel:!string, adbSerial:!string, browsers:!Array.<!Adb.Browser >, adbPortStatus:!Array.<number>, adbConnected: boolean}} 37 * @typedef {{id: string, adbModel: string, adbSerial: string, browsers: !Array. <!Adb.Browser>, adbPortStatus: !Array.<number>, adbConnected: boolean}}
38 */ 38 */
39 Adb.Device; 39 Adb.Device;
40 40
41 WebInspector.DevicesView.Events = { 41 WebInspector.DevicesView.Events = {
42 DevicesChanged: "DevicesChanged" 42 DevicesChanged: "DevicesChanged"
43 }; 43 };
44 44
45 WebInspector.DevicesView.prototype = { 45 WebInspector.DevicesView.prototype = {
46 _onDevicesChanged: function(event) 46 _onDevicesChanged: function(event)
47 { 47 {
48 this._updateDeviceList(/** @type {!Array.<!Adb.Device>} */(event.data)); 48 this._updateDeviceList(/** @type {!Array.<!Adb.Device>} */(event.data));
49 }, 49 },
50 50
51 /** 51 /**
52 * @param {!Array.<!Adb.Device>} devices 52 * @param {!Array.<!Adb.Device>} devices
53 */ 53 */
54 _updateDeviceList: function(devices) 54 _updateDeviceList: function(devices)
55 { 55 {
56 /** 56 /**
57 * @param {!string} id 57 * @param {string} id
58 * @return {string} 58 * @return {string}
59 */ 59 */
60 function sanitizeForId(id) 60 function sanitizeForId(id)
61 { 61 {
62 return id.replace(/[.:/\/ ]/g, "-"); 62 return id.replace(/[.:/\/ ]/g, "-");
63 } 63 }
64 64
65 /** 65 /**
66 * @param {!Element} element 66 * @param {!Element} element
67 * @param {!Object} data 67 * @param {!Object} data
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 WebInspector.inspectorFrontendEventSink.removeEventListener(WebInspector .DevicesView.Events.DevicesChanged, this._onDevicesChanged, this); 177 WebInspector.inspectorFrontendEventSink.removeEventListener(WebInspector .DevicesView.Events.DevicesChanged, this._onDevicesChanged, this);
178 }, 178 },
179 179
180 wasShown: function() 180 wasShown: function()
181 { 181 {
182 WebInspector.inspectorFrontendEventSink.addEventListener(WebInspector.De vicesView.Events.DevicesChanged, this._onDevicesChanged, this); 182 WebInspector.inspectorFrontendEventSink.addEventListener(WebInspector.De vicesView.Events.DevicesChanged, this._onDevicesChanged, this);
183 }, 183 },
184 184
185 __proto__: WebInspector.VBox.prototype 185 __proto__: WebInspector.VBox.prototype
186 }; 186 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698