DevTools: Add JSDoc for static methods, fix JSDoc types and induced errors

Source/devtools/front_end/ScreencastView.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 231 matching lines @@
         var dimensions = this._viewportDimensions();
         this._screenZoom = Math.min(dimensions.width / screenWidthDIP, dimensions.height / screenHeightDIP);
 
         var bordersSize = WebInspector.ScreencastView._bordersSize;
         this._viewportElement.classList.remove("hidden");
         this._viewportElement.style.width = screenWidthDIP * this._screenZoom + bordersSize + "px";
         this._viewportElement.style.height = screenHeightDIP * this._screenZoom + bordersSize + "px";
     },
 
     /**
-     * @param {!Event} event
+     * @param {?Event} event

[yurys, 2014/06/17 11:32:28]

When can event be null?

[apavlov, 2014/06/17 12:46:03]

This is how it is specified in the compiler own externs

      */
     _handleMouseEvent: function(event)
     {
         if (this._isGlassPaneActive()) {
           event.consume();
           return;
         }
 
         if (!this._viewport)
             return;
@@ skipping 18 matching lines @@
             if (!node)
                 return;
             if (event.type === "mousemove")
                 node.highlight(this._inspectModeConfig);
             else if (event.type === "click")
                 node.reveal();
         }
     },
 
     /**
-     * @param {!KeyboardEvent} event
+     * @param {?Event} event
      */
     _handleKeyEvent: function(event)
     {
         if (this._isGlassPaneActive()) {
             event.consume();
             return;
         }
 
-        var shortcutKey = WebInspector.KeyboardShortcut.makeKeyFromEvent(event);
+        var shortcutKey = WebInspector.KeyboardShortcut.makeKeyFromEvent(/** @type {!KeyboardEvent} */ (event));
         var handler = this._shortcuts[shortcutKey];
         if (handler && handler(event)) {
             event.consume();
             return;
         }
 
         var type;
         switch (event.type) {
         case "keydown": type = "keyDown"; break;
         case "keyup": type = "keyUp"; break;
         case "keypress": type = "char"; break;
         default: return;
         }
 
         var text = event.type === "keypress" ? String.fromCharCode(event.charCode) : undefined;
         InputAgent.dispatchKeyEvent(type, this._modifiersForEvent(event), event.timeStamp / 1000, text, text ? text.toLowerCase() : undefined,
                                     event.keyIdentifier, event.keyCode /* windowsVirtualKeyCode */, event.keyCode /* nativeVirtualKeyCode */, false, false, false);
         event.consume();
         this._canvasElement.focus();
     },
 
     /**
-     * @param {!Event} event
+     * @param {?Event} event
      */
     _handleContextMenuEvent: function(event)
     {
         event.consume(true);
     },
 
     /**
-     * @param {!Event} event
+     * @param {?Event} event
      */
     _simulateTouchGestureForMouseEvent: function(event)
     {
         var convertedPosition = this._convertIntoScreenSpace(event);
         var zoomedPosition = this._zoomIntoScreenSpace(event);
         var timeStamp = event.timeStamp / 1000;
 
         /**
          * @this {!WebInspector.ScreencastView}
          */
@@ skipping 140 matching lines @@
             }
             break;
 
         case 3: // Right
         case 0: // None
         default:
         }
     },
 
     /**
-     * @param {!Event} event
+     * @param {?Event} event
      * @return {!{x: number, y: number}}
      */
     _zoomIntoScreenSpace: function(event)
     {
         var zoom = this._canvasElement.offsetWidth / this._viewport.width / this._pageScaleFactor;
         var position  = {};
         position.x = Math.round(event.offsetX / zoom);
         position.y = Math.round(event.offsetY / zoom);
         return position;
     },
 
     /**
-     * @param {!Event} event
+     * @param {?Event} event
      * @return {!{x: number, y: number}}
      */
     _convertIntoScreenSpace: function(event)
     {
         var position = this._zoomIntoScreenSpace(event);
         position.y = Math.round(position.y - this._screenOffsetTop);
         return position;
     },
 
     /**
-     * @param {!Event} event
+     * @param {?Event} event
      * @return {number}
      */
     _modifiersForEvent: function(event)
     {
         var modifiers = 0;
         if (event.altKey)
             modifiers = 1;
         if (event.ctrlKey)
             modifiers += 2;
         if (event.metaKey)
@@ skipping 409 matching lines @@
     {
         this._navigationUrl.focus();
         this._navigationUrl.select();
         return true;
     },
 
   __proto__: WebInspector.VBox.prototype
 }
 
 /**
- * @param {!HTMLElement} element
+ * @param {!Element} element
  * @constructor
  */
 WebInspector.ScreencastView.ProgressTracker = function(element) {
     this._element = element;
 
     WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);
     WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._onLoad, this);
 
     WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestStarted, this._onRequestStarted, this);
     WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestFinished, this);
@@ skipping 57 matching lines @@
           return;
         this._maxDisplayedProgress = progress;
         this._displayProgress(progress);
     },
 
     _displayProgress: function(progress)
     {
         this._element.style.width = (100 * progress) + "%";
     }
 };