Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 340503002: Initialize all CSSParserValue's variables (Closed)

Created:
6 years, 6 months ago by Yoav Weiss
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune, do_not_use, alancutter (OOO until 2018), apavlov
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Initialize all CSSParserValue's variables The isInt variable of CSSParserValue was often not initialized in CSSGrammar.y. This CL fixes that. BUG=385386 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176323

Patch Set 1 #

Patch Set 2 : Another CSSParserValue uninit var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M Source/core/css/CSSGrammar.y View 3 chunks +10 lines, -8 lines 0 comments Download
M Source/core/css/CSSParserValues.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yoav Weiss
Initialized isInt in all the instances of CSSParserValue creation I could find.
6 years, 6 months ago (2014-06-17 08:33:25 UTC) #1
Yoav Weiss
On 2014/06/17 08:33:25, Yoav Weiss wrote: > Initialized isInt in all the instances of CSSParserValue ...
6 years, 6 months ago (2014-06-17 09:00:41 UTC) #2
eseidel
lgtm CSSParserValue really just needs a constructor and more normal refcounting. I feel like I ...
6 years, 6 months ago (2014-06-17 15:39:04 UTC) #3
Yoav Weiss
On 2014/06/17 15:39:04, eseidel wrote: > lgtm > > CSSParserValue really just needs a constructor ...
6 years, 6 months ago (2014-06-17 15:45:42 UTC) #4
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-06-17 15:45:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/340503002/20001
6 years, 6 months ago (2014-06-17 15:46:28 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 15:50:09 UTC) #7
Message was sent while issue was closed.
Change committed as 176323

Powered by Google App Engine
This is Rietveld 408576698