Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 340473002: core build: Remove unnecessary include_dirs (bindings cruft) (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, c.shu, tasak (please_use_google.com)
Project:
blink
Visibility:
Public.

Description

core build: Remove unnecessary include_dirs (bindings cruft) The core:core_generated target previously needed many include_dirs in its path, due to unqualified include statements. These have been resolved, and now we can remove them! R=haraken BUG=377364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M Source/bindings/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Remove old include cruft!
6 years, 6 months ago (2014-06-17 06:41:15 UTC) #1
haraken
LGTM!
6 years, 6 months ago (2014-06-17 06:45:49 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-17 06:46:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/340473002/1
6 years, 6 months ago (2014-06-17 06:46:52 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 07:59:23 UTC) #5
Message was sent while issue was closed.
Change committed as 176294

Powered by Google App Engine
This is Rietveld 408576698