Issue 340473002: core build: Remove unnecessary include_dirs (bindings cruft)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340473002: core build: Remove unnecessary include_dirs (bindings cruft) (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, c.shu, tasak (please_use_google.com)

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

core build: Remove unnecessary include_dirs (bindings cruft) The core:core_generated target previously needed many include_dirs in its path, due to unqualified include statements. These have been resolved, and now we can remove them! R=haraken BUG=377364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176294

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -17 lines)			Patch
M	Source/bindings/v8/custom/custom.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/BUILD.gn	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/core.gyp	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 6 months ago (2014-06-17 06:46:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/340473002/1

6 years, 6 months ago (2014-06-17 06:46:52 UTC) #4

Message was sent while issue was closed.

Change committed as 176294

Expand Messages | Collapse Messages