Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 340443004: IDL: reuse more code between CG for methods and constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rename scriptContext -> executionContext Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp
index 5c375c91bcc101a228ce2f8bb4d3691637d90219..e349fd6cc451346c656ded117494a66a80559021 100644
--- a/Source/bindings/tests/results/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/V8TestInterface.cpp
@@ -641,8 +641,8 @@ static void partialCallWithExecutionContextLongAttributeAttributeGetter(const v8
{
v8::Handle<v8::Object> holder = info.Holder();
TestInterfaceImplementation* impl = V8TestInterface::toNative(holder);
- ExecutionContext* scriptContext = currentExecutionContext(info.GetIsolate());
- v8SetReturnValueInt(info, TestPartialInterface::partialCallWithExecutionContextLongAttribute(scriptContext, *impl));
+ ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
+ v8SetReturnValueInt(info, TestPartialInterface::partialCallWithExecutionContextLongAttribute(executionContext, *impl));
}
#endif // ENABLE(PARTIAL_CONDITION)
@@ -662,8 +662,8 @@ static void partialCallWithExecutionContextLongAttributeAttributeSetter(v8::Loca
ExceptionState exceptionState(ExceptionState::SetterContext, "partialCallWithExecutionContextLongAttribute", "TestInterface", holder, info.GetIsolate());
TestInterfaceImplementation* impl = V8TestInterface::toNative(holder);
TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
- ExecutionContext* scriptContext = currentExecutionContext(info.GetIsolate());
- TestPartialInterface::setPartialCallWithExecutionContextLongAttribute(scriptContext, *impl, cppValue);
+ ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
+ TestPartialInterface::setPartialCallWithExecutionContextLongAttribute(executionContext, *impl, cppValue);
}
#endif // ENABLE(PARTIAL_CONDITION)
@@ -938,8 +938,8 @@ static void implementsComplexMethodMethod(const v8::FunctionCallbackInfo<v8::Val
}
TONATIVE_VOID_INTERNAL(testInterfaceEmptyArg, V8TestInterfaceEmpty::toNativeWithTypeCheck(info.GetIsolate(), info[1]));
}
- ExecutionContext* scriptContext = currentExecutionContext(info.GetIsolate());
- RefPtr<TestInterfaceEmpty> result = impl->implementsComplexMethod(scriptContext, strArg, testInterfaceEmptyArg, exceptionState);
+ ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
+ RefPtr<TestInterfaceEmpty> result = impl->implementsComplexMethod(executionContext, strArg, testInterfaceEmptyArg, exceptionState);
if (exceptionState.hadException()) {
exceptionState.throwIfNeeded();
return;
@@ -1077,8 +1077,8 @@ static void partialCallWithExecutionContextRaisesExceptionVoidMethodMethod(const
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "partialCallWithExecutionContextRaisesExceptionVoidMethod", "TestInterface", info.Holder(), info.GetIsolate());
TestInterfaceImplementation* impl = V8TestInterface::toNative(info.Holder());
- ExecutionContext* scriptContext = currentExecutionContext(info.GetIsolate());
- TestPartialInterface::partialCallWithExecutionContextRaisesExceptionVoidMethod(scriptContext, *impl, exceptionState);
+ ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
+ TestPartialInterface::partialCallWithExecutionContextRaisesExceptionVoidMethod(executionContext, *impl, exceptionState);
if (exceptionState.hadException()) {
exceptionState.throwIfNeeded();
return;

Powered by Google App Engine
This is Rietveld 408576698