Source/bindings/scripts/idl_definitions.py - Issue 340443004: IDL: reuse more code between CG for methods and constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_definitions.py

Issue 340443004: IDL: reuse more code between CG for methods and constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/idl_definitions.py

diff --git a/Source/bindings/scripts/idl_definitions.py b/Source/bindings/scripts/idl_definitions.py

index 9ed52133763880d1dfd0a6df4546551579d168af..50664ba12ef7addd5cb3cbc69484e0629231ba3d 100644

--- a/Source/bindings/scripts/idl_definitions.py

+++ b/Source/bindings/scripts/idl_definitions.py

@@ -455,6 +455,7 @@ class IdlOperation(TypedObject):

self.arguments = []

self.extended_attributes = {}

self.specials = []

+ self.is_constructor = False

if not node:

self.is_static = False

@@ -509,6 +510,7 @@ class IdlOperation(TypedObject):

constructor = cls()

constructor.name = name

constructor.arguments = arguments_node_to_arguments(arguments_node)

+ constructor.is_constructor = True

return constructor

def resolve_typedefs(self, typedefs):

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_attributes.py » ('j') | Source/bindings/templates/methods.cpp » ('J')