IDL: reuse more code between CG for methods and constructors

Source/bindings/scripts/v8_interface.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 # coding=utf-8
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 819 matching lines @@
 ################################################################################
 # Constructors
 ################################################################################
 
 # [Constructor]
 def generate_constructor(interface, constructor):
     arguments_need_try_catch = any(v8_methods.argument_needs_try_catch(argument)
                                    for argument in constructor.arguments)
 
     return {
-        'argument_list': constructor_argument_list(interface, constructor),
         'arguments': [v8_methods.generate_argument(interface, constructor, argument, index)
                       for index, argument in enumerate(constructor.arguments)],
         'arguments_need_try_catch': arguments_need_try_catch,
         'cpp_type': cpp_template_type(
             cpp_ptr_type('RefPtr', 'RawPtr', gc_type(interface)),
             cpp_name(interface)),
+        'cpp_value': v8_methods.cpp_value(
+            interface, constructor, len(constructor.arguments)),
         'has_exception_state':
             # [RaisesException=Constructor]
             interface.extended_attributes.get('RaisesException') == 'Constructor' or
             any(argument for argument in constructor.arguments
                 if argument.idl_type.name == 'SerializedScriptValue' or
                    argument.idl_type.is_integer_type),
         'is_constructor': True,
         'is_named_constructor': False,
         'number_of_required_arguments':
             number_of_required_arguments(constructor),
     }
 
 
-def constructor_argument_list(interface, constructor):
-    arguments = []
-    # [ConstructorCallWith=ExecutionContext]
-    if has_extended_attribute_value(interface, 'ConstructorCallWith', 'ExecutionContext'):
-        arguments.append('context')
-    # [ConstructorCallWith=Document]
-    if has_extended_attribute_value(interface, 'ConstructorCallWith', 'Document'):
-        arguments.append('document')
-
-    arguments.extend([argument.name for argument in constructor.arguments])
-
-    # [RaisesException=Constructor]
-    if interface.extended_attributes.get('RaisesException') == 'Constructor':
-        arguments.append('exceptionState')
-
-    return arguments
-
-
 # [NamedConstructor]
 def generate_named_constructor(interface):
     extended_attributes = interface.extended_attributes
     if 'NamedConstructor' not in extended_attributes:
         return None
     # FIXME: parser should return named constructor separately;
     # included in constructors (and only name stored in extended attribute)
     # for Perl compatibility
-    idl_constructor = interface.constructors[0]
+    idl_constructor = interface.constructors[-1]
+    assert idl_constructor.name == 'NamedConstructor'
     constructor = generate_constructor(interface, idl_constructor)
-    constructor['argument_list'].insert(0, '*document')
     constructor.update({
         'name': extended_attributes['NamedConstructor'],
         'is_named_constructor': True,
     })
     return constructor
 
 
 def number_of_required_arguments(constructor):
     return len([argument for argument in constructor.arguments
                 if not argument.is_optional])
@@ skipping 191 matching lines @@
         deleter = next(
             method
             for method in interface.operations
             if ('deleter' in method.specials and
                 len(method.arguments) == 1 and
                 str(method.arguments[0].idl_type) == 'DOMString'))
     except StopIteration:
         return None
 
     return property_deleter(deleter)