net/tools/quic/quic_time_wait_list_manager.cc - Issue 340433002: Port QuicServer to Chrome network stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_time_wait_list_manager.cc

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_time_wait_list_manager.cc

diff --git a/net/tools/quic/quic_time_wait_list_manager.cc b/net/tools/quic/quic_time_wait_list_manager.cc

index 9744ff89e5370e09ce144bb01105e73cb84867c5..01446c08825717bb802b8e32ce3e326b70f0b1e2 100644

--- a/net/tools/quic/quic_time_wait_list_manager.cc

+++ b/net/tools/quic/quic_time_wait_list_manager.cc

@@ -233,7 +233,8 @@ bool QuicTimeWaitListManager::WriteToWire(QueuedPacket* queued_packet) {

queued_packet->packet()->data(),

queued_packet->packet()->length(),

queued_packet->server_address().address(),

- queued_packet->client_address());

+ queued_packet->client_address(),

+ base::Callback<void(WriteResult wr)>());

if (result.status == WRITE_STATUS_BLOCKED) {

// If blocked and unbuffered, return false to retry sending.

DCHECK(writer_->IsWriteBlocked());