net/tools/quic/quic_default_packet_writer.cc - Issue 340433002: Port QuicServer to Chrome network stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_default_packet_writer.cc

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_default_packet_writer.cc

diff --git a/net/tools/quic/quic_default_packet_writer.cc b/net/tools/quic/quic_default_packet_writer.cc

index ff83be6d0c5c5b26ec070eada6c5f47f5c27d5d0..fe7420a2f60647549184f43b1358943d7a44fb85 100644

--- a/net/tools/quic/quic_default_packet_writer.cc

+++ b/net/tools/quic/quic_default_packet_writer.cc

@@ -18,7 +18,8 @@ QuicDefaultPacketWriter::~QuicDefaultPacketWriter() {}

WriteResult QuicDefaultPacketWriter::WritePacket(

const char* buffer, size_t buf_len,

const net::IPAddressNumber& self_address,

- const net::IPEndPoint& peer_address) {

+ const net::IPEndPoint& peer_address,

+ base::Callback<void(WriteResult wr)> callback) {

DCHECK(!IsWriteBlocked());

WriteResult result = QuicSocketUtils::WritePacket(

fd_, buffer, buf_len, self_address, peer_address);