net/quic/test_tools/quic_test_utils.h - Issue 340433002: Port QuicServer to Chrome network stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/quic_test_utils.h

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/test_tools/quic_test_utils.h

diff --git a/net/quic/test_tools/quic_test_utils.h b/net/quic/test_tools/quic_test_utils.h

index 4c6fcf1c1780771235910d9556ab0bc5bc2f6ae0..8794044acd8dd65a7703d1342f43b52876c9db17 100644

--- a/net/quic/test_tools/quic_test_utils.h

+++ b/net/quic/test_tools/quic_test_utils.h

@@ -399,11 +399,12 @@ class MockPacketWriter : public QuicPacketWriter {

MockPacketWriter();

virtual ~MockPacketWriter();

- MOCK_METHOD4(WritePacket,

+ MOCK_METHOD5(WritePacket,

WriteResult(const char* buffer,

size_t buf_len,

const IPAddressNumber& self_address,

- const IPEndPoint& peer_address));

+ const IPEndPoint& peer_address,

+ base::Callback<void(WriteResult wr)> callback));

MOCK_CONST_METHOD0(IsWriteBlockedDataBuffered, bool());

MOCK_CONST_METHOD0(IsWriteBlocked, bool());

MOCK_METHOD0(SetWritable, void());