net/quic/quic_connection.h - Issue 340433002: Port QuicServer to Chrome network stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection.h

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_connection.h

diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h

index 35de041591a1f8096956f09d38fa41625d228261..e47f5755880dac51230a40b25e490279b4963076 100644

--- a/net/quic/quic_connection.h

+++ b/net/quic/quic_connection.h

@@ -765,6 +765,8 @@ class NET_EXPORT_PRIVATE QuicConnection

// version negotiation packet.

QuicVersionVector server_supported_versions_;

+ base::WeakPtrFactory<QuicConnection> weak_factory_;

Ryan Hamilton 2014/06/18 23:59:51 This is chrome specific, and probably shouldn't go

dmz 2014/06/19 17:46:24 Removed.

DISALLOW_COPY_AND_ASSIGN(QuicConnection);

};