Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: net/quic/quic_server_packet_writer.cc

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix invalid memory access + blocked writers Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_server_packet_writer.cc
diff --git a/net/quic/quic_server_packet_writer.cc b/net/quic/quic_server_packet_writer.cc
index c2635b699eb3efd06713015d8ba6fcd1a2d93a4e..a4b0d34a8cd62109086670d0ac325a7123e577ad 100644
--- a/net/quic/quic_server_packet_writer.cc
+++ b/net/quic/quic_server_packet_writer.cc
@@ -9,15 +9,19 @@
#include "base/metrics/sparse_histogram.h"
#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
+#include "net/quic/quic_dispatcher.h"
wtc 2014/06/18 02:04:47 Remove this header?
dmziegler 2014/06/18 20:13:41 Done.
namespace net {
QuicServerPacketWriter::QuicServerPacketWriter() : weak_factory_(this) {
}
-QuicServerPacketWriter::QuicServerPacketWriter(UDPServerSocket* socket)
+QuicServerPacketWriter::QuicServerPacketWriter(
+ QuicServerPacketWriterVisitor* visitor,
+ UDPServerSocket* socket)
: weak_factory_(this),
socket_(socket),
+ visitor_(visitor),
write_blocked_(false) {
}
@@ -69,6 +73,7 @@ void QuicServerPacketWriter::OnWriteComplete(int rv) {
WriteResult result(rv < 0 ? WRITE_STATUS_ERROR : WRITE_STATUS_OK, rv);
connection_->OnPacketSent(result);
connection_->OnCanWrite();
+ visitor_->OnCanWrite();
wtc 2014/06/18 02:04:47 It is strange that we are invoking the OnCanWrite(
dmziegler 2014/06/18 20:13:41 Now there's one Callback and one QuicBlockedWriter
}
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698