Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: net/quic/quic_server_packet_writer.cc

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_server_packet_writer.h" 5 #include "net/quic/quic_server_packet_writer.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop/message_loop.h"
9 #include "base/metrics/sparse_histogram.h" 10 #include "base/metrics/sparse_histogram.h"
10 #include "net/base/io_buffer.h" 11 #include "net/base/io_buffer.h"
11 #include "net/base/net_errors.h" 12 #include "net/base/net_errors.h"
13 #include "net/quic/crypto/quic_random.h"
12 14
13 namespace net { 15 namespace net {
14 16
15 QuicServerPacketWriter::QuicServerPacketWriter() : weak_factory_(this) {
16 }
17
18 QuicServerPacketWriter::QuicServerPacketWriter(UDPServerSocket* socket) 17 QuicServerPacketWriter::QuicServerPacketWriter(UDPServerSocket* socket)
19 : weak_factory_(this), 18 : weak_factory_(this),
20 socket_(socket), 19 socket_(socket),
21 write_blocked_(false) { 20 write_blocked_(false) {
22 } 21 }
23 22
24 QuicServerPacketWriter::~QuicServerPacketWriter() { 23 QuicServerPacketWriter::~QuicServerPacketWriter() {
25 } 24 }
26 25
27 WriteResult QuicServerPacketWriter::WritePacket( 26 WriteResult QuicServerPacketWriter::WritePacket(
28 const char* buffer, size_t buf_len, 27 const char* buffer, size_t buf_len,
29 const net::IPAddressNumber& self_address, 28 const IPAddressNumber& self_address,
30 const net::IPEndPoint& peer_address) { 29 const IPEndPoint& peer_address,
30 base::Callback<void(WriteResult wr)> callback) {
31 scoped_refptr<StringIOBuffer> buf( 31 scoped_refptr<StringIOBuffer> buf(
32 new StringIOBuffer(std::string(buffer, buf_len))); 32 new StringIOBuffer(std::string(buffer, buf_len)));
33 DCHECK(!IsWriteBlocked()); 33 DCHECK(!IsWriteBlocked());
34 int rv = socket_->SendTo(buf.get(), 34 int rv = socket_->SendTo(buf.get(),
35 buf_len, 35 buf_len,
36 peer_address, 36 peer_address,
37 base::Bind(&QuicServerPacketWriter::OnWriteComplete, 37 base::Bind(&QuicServerPacketWriter::OnWriteComplete,
38 weak_factory_.GetWeakPtr())); 38 weak_factory_.GetWeakPtr()));
39 WriteStatus status = WRITE_STATUS_OK; 39 WriteStatus status = WRITE_STATUS_OK;
40 if (rv < 0) { 40 if (rv < 0) {
41 if (rv != ERR_IO_PENDING) { 41 if (rv != ERR_IO_PENDING) {
42 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.WriteError", -rv); 42 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.WriteError", -rv);
43 status = WRITE_STATUS_ERROR; 43 status = WRITE_STATUS_ERROR;
44 } else { 44 } else {
45 status = WRITE_STATUS_BLOCKED; 45 status = WRITE_STATUS_BLOCKED;
46 write_blocked_ = true; 46 write_blocked_ = true;
47 callback_ = callback;
47 } 48 }
48 } 49 }
49
50 return WriteResult(status, rv); 50 return WriteResult(status, rv);
51 } 51 }
52 52
53 bool QuicServerPacketWriter::IsWriteBlockedDataBuffered() const { 53 bool QuicServerPacketWriter::IsWriteBlockedDataBuffered() const {
54 // UDPServerSocket::SendTo buffers the data until the Write is permitted. 54 // UDPServerSocket::SendTo buffers the data until the Write is permitted.
55 return true; 55 return true;
56 } 56 }
57 57
58 bool QuicServerPacketWriter::IsWriteBlocked() const { 58 bool QuicServerPacketWriter::IsWriteBlocked() const {
59 return write_blocked_; 59 return write_blocked_;
60 } 60 }
61 61
62 void QuicServerPacketWriter::SetWritable() { 62 void QuicServerPacketWriter::SetWritable() {
63 write_blocked_ = false; 63 write_blocked_ = false;
64 } 64 }
65 65
66 void QuicServerPacketWriter::OnWriteComplete(int rv) { 66 void QuicServerPacketWriter::OnWriteComplete(int rv) {
67 DCHECK_NE(rv, ERR_IO_PENDING); 67 DCHECK_NE(rv, ERR_IO_PENDING);
68 write_blocked_ = false; 68 write_blocked_ = false;
69 WriteResult result(rv < 0 ? WRITE_STATUS_ERROR : WRITE_STATUS_OK, rv); 69 WriteResult result(rv < 0 ? WRITE_STATUS_ERROR : WRITE_STATUS_OK, rv);
70 connection_->OnPacketSent(result); 70 if (!callback_.is_null()) {
71 connection_->OnCanWrite(); 71 callback_.Run(result);
72 }
73 blocked_writer_->OnCanWrite();
72 } 74 }
73 75
74 } // namespace net 76 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698