Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: net/quic/quic_default_packet_writer.cc

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments and fix blocked writers using callbacks Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_default_packet_writer.h" 5 #include "net/quic/quic_default_packet_writer.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/metrics/sparse_histogram.h" 9 #include "base/metrics/sparse_histogram.h"
10 #include "net/base/io_buffer.h" 10 #include "net/base/io_buffer.h"
11 #include "net/base/net_errors.h" 11 #include "net/base/net_errors.h"
12 12
13 namespace net { 13 namespace net {
14 14
15 QuicDefaultPacketWriter::QuicDefaultPacketWriter() : weak_factory_(this) { 15 QuicDefaultPacketWriter::QuicDefaultPacketWriter() : weak_factory_(this) {
16 } 16 }
17 17
18 QuicDefaultPacketWriter::QuicDefaultPacketWriter(DatagramClientSocket* socket) 18 QuicDefaultPacketWriter::QuicDefaultPacketWriter(DatagramClientSocket* socket)
19 : weak_factory_(this), 19 : weak_factory_(this),
20 socket_(socket), 20 socket_(socket),
21 write_blocked_(false) { 21 write_blocked_(false) {
22 } 22 }
23 23
24 QuicDefaultPacketWriter::~QuicDefaultPacketWriter() {} 24 QuicDefaultPacketWriter::~QuicDefaultPacketWriter() {}
25 25
26 WriteResult QuicDefaultPacketWriter::WritePacket( 26 WriteResult QuicDefaultPacketWriter::WritePacket(
27 const char* buffer, size_t buf_len, 27 const char* buffer, size_t buf_len,
28 const net::IPAddressNumber& self_address, 28 const net::IPAddressNumber& self_address,
29 const net::IPEndPoint& peer_address) { 29 const net::IPEndPoint& peer_address,
30 base::Callback<void(WriteResult wr)> callback) {
30 scoped_refptr<StringIOBuffer> buf( 31 scoped_refptr<StringIOBuffer> buf(
31 new StringIOBuffer(std::string(buffer, buf_len))); 32 new StringIOBuffer(std::string(buffer, buf_len)));
32 DCHECK(!IsWriteBlocked()); 33 DCHECK(!IsWriteBlocked());
33 int rv = socket_->Write(buf.get(), 34 int rv = socket_->Write(buf.get(),
34 buf_len, 35 buf_len,
35 base::Bind(&QuicDefaultPacketWriter::OnWriteComplete, 36 base::Bind(&QuicDefaultPacketWriter::OnWriteComplete,
36 weak_factory_.GetWeakPtr())); 37 weak_factory_.GetWeakPtr()));
37 WriteStatus status = WRITE_STATUS_OK; 38 WriteStatus status = WRITE_STATUS_OK;
38 if (rv < 0) { 39 if (rv < 0) {
39 if (rv != ERR_IO_PENDING) { 40 if (rv != ERR_IO_PENDING) {
40 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.WriteError", -rv); 41 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.WriteError", -rv);
41 status = WRITE_STATUS_ERROR; 42 status = WRITE_STATUS_ERROR;
42 } else { 43 } else {
43 status = WRITE_STATUS_BLOCKED; 44 status = WRITE_STATUS_BLOCKED;
44 write_blocked_ = true; 45 write_blocked_ = true;
46 callback_ = callback;
45 } 47 }
46 } 48 }
47 49
48 return WriteResult(status, rv); 50 return WriteResult(status, rv);
49 } 51 }
50 52
51 bool QuicDefaultPacketWriter::IsWriteBlockedDataBuffered() const { 53 bool QuicDefaultPacketWriter::IsWriteBlockedDataBuffered() const {
52 // Chrome sockets' Write() methods buffer the data until the Write is 54 // Chrome sockets' Write() methods buffer the data until the Write is
53 // permitted. 55 // permitted.
54 return true; 56 return true;
55 } 57 }
56 58
57 bool QuicDefaultPacketWriter::IsWriteBlocked() const { 59 bool QuicDefaultPacketWriter::IsWriteBlocked() const {
58 return write_blocked_; 60 return write_blocked_;
59 } 61 }
60 62
61 void QuicDefaultPacketWriter::SetWritable() { 63 void QuicDefaultPacketWriter::SetWritable() {
62 write_blocked_ = false; 64 write_blocked_ = false;
63 } 65 }
64 66
65 void QuicDefaultPacketWriter::OnWriteComplete(int rv) { 67 void QuicDefaultPacketWriter::OnWriteComplete(int rv) {
66 DCHECK_NE(rv, ERR_IO_PENDING); 68 DCHECK_NE(rv, ERR_IO_PENDING);
67 write_blocked_ = false; 69 write_blocked_ = false;
68 WriteResult result(rv < 0 ? WRITE_STATUS_ERROR : WRITE_STATUS_OK, rv); 70 WriteResult result(rv < 0 ? WRITE_STATUS_ERROR : WRITE_STATUS_OK, rv);
69 connection_->OnPacketSent(result); 71 if (!callback_.is_null()) {
70 connection_->OnCanWrite(); 72 callback_.Run(result);
73 }
74 blocked_writer_->OnCanWrite();
71 } 75 }
72 76
73 } // namespace net 77 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698