Port QuicServer to Chrome network stack

net/quic/quic_server_packet_writer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_
 #define NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_
 
 #include "base/basictypes.h"
 #include "base/memory/weak_ptr.h"
 #include "net/base/ip_endpoint.h"
 #include "net/quic/quic_connection.h"
 #include "net/quic/quic_packet_writer.h"
 #include "net/quic/quic_protocol.h"
 #include "net/udp/udp_server_socket.h"
 
 namespace net {
 
+class QuicDispatcher;

[wtc, 2014/06/18 02:04:47]

Delete the unused forward declaration.

[dmziegler, 2014/06/18 20:13:42]

Done.

 struct WriteResult;

[wtc, 2014/06/18 02:04:47]

I think this forward declaration can be removed. I'd be surprised that a forward
declaration of struct WriteResult is enough. I think this header needs the
definition of this struct.

[dmziegler, 2014/06/18 20:13:41]

Done.

 
+class QuicServerPacketWriterVisitor {
+ public:
+  virtual ~QuicServerPacketWriterVisitor() {}
+
+  virtual void OnCanWrite() {}

[wtc, 2014/06/18 02:04:47]

Document this method.

This method should be abstract (= 0).

[dmziegler, 2014/06/18 20:13:42]

(This got deleted)

+};
+
 // Chrome specific packet writer which uses a UDPServerSocket for writing
 // data.
 class QuicServerPacketWriter : public QuicPacketWriter {
  public:
   QuicServerPacketWriter();
-  explicit QuicServerPacketWriter(UDPServerSocket* socket);
+  QuicServerPacketWriter(QuicServerPacketWriterVisitor* visitor,
+                         UDPServerSocket* socket);
   virtual ~QuicServerPacketWriter();
 
   // QuicPacketWriter
   virtual WriteResult WritePacket(const char* buffer,
                                   size_t buf_len,
-                                  const net::IPAddressNumber& self_address,
-                                  const net::IPEndPoint& peer_address) OVERRIDE;
+                                  const IPAddressNumber& self_address,
+                                  const IPEndPoint& peer_address) OVERRIDE;
   virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;
   virtual bool IsWriteBlocked() const OVERRIDE;
   virtual void SetWritable() OVERRIDE;
 
   void OnWriteComplete(int rv);
   void SetConnection(QuicConnection* connection) {
     connection_ = connection;
   }
 
  private:
   base::WeakPtrFactory<QuicServerPacketWriter> weak_factory_;
   UDPServerSocket* socket_;
+  QuicServerPacketWriterVisitor* visitor_;

[wtc, 2014/06/18 02:04:47]

Nit: the order of these two members should match the order of the equivalent
constructor arguments.

[dmziegler, 2014/06/18 20:13:41]

No longer in the constructor.

   QuicConnection* connection_;
   bool write_blocked_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicServerPacketWriter);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_