Port QuicServer to Chrome network stack

net/quic/quic_server_packet_writer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_
 #define NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_
 
 #include "base/basictypes.h"
 #include "base/memory/weak_ptr.h"
 #include "net/base/ip_endpoint.h"
 #include "net/quic/quic_connection.h"
 #include "net/quic/quic_packet_writer.h"
 #include "net/quic/quic_protocol.h"
+#include "net/quic/quic_types.h"
 #include "net/udp/udp_server_socket.h"

[wtc, 2014/06/20 21:40:50]

A forward declaration of class UDPServerSocket may be enough.

[dmziegler, 2014/06/23 18:31:25]

Done.

 
 namespace net {
 
-struct WriteResult;
+class QuicBlockedWriterInterface;
 
 // Chrome specific packet writer which uses a UDPServerSocket for writing
 // data.
 class QuicServerPacketWriter : public QuicPacketWriter {
  public:
-  QuicServerPacketWriter();
-  explicit QuicServerPacketWriter(UDPServerSocket* socket);
+  typedef base::Callback<void(WriteResult)> WriteCallback;
+
+  QuicServerPacketWriter(QuicBlockedWriterInterface* blocked_writer,
+                         UDPServerSocket* socket);

[wtc, 2014/06/20 21:40:50]

Nit: I would reorder these two parameters because the |socket| seems more
important to a packet writer.

[dmziegler, 2014/06/23 18:31:24]

Done.

   virtual ~QuicServerPacketWriter();
 
+  virtual WriteResult WritePacketWithCallback(

[wtc, 2014/06/20 21:40:50]

Document this method.

[dmziegler, 2014/06/23 18:31:24]

Done.

+      const char* buffer,
+      size_t buf_len,
+      const IPAddressNumber& self_address,
+      const IPEndPoint& peer_address,
+      WriteCallback callback);
+
   // QuicPacketWriter
   virtual WriteResult WritePacket(const char* buffer,
                                   size_t buf_len,
-                                  const net::IPAddressNumber& self_address,
-                                  const net::IPEndPoint& peer_address) OVERRIDE;
+                                  const IPAddressNumber& self_address,
+                                  const IPEndPoint& peer_address) OVERRIDE;
   virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;
   virtual bool IsWriteBlocked() const OVERRIDE;
   virtual void SetWritable() OVERRIDE;
 
   void OnWriteComplete(int rv);
-  void SetConnection(QuicConnection* connection) {
-    connection_ = connection;
-  }
+
 
  private:
   base::WeakPtrFactory<QuicServerPacketWriter> weak_factory_;
   UDPServerSocket* socket_;
-  QuicConnection* connection_;
+
+  // To be notified after every successful asynchronous write.
+  QuicBlockedWriterInterface* blocked_writer_;
+  base::Callback<void(WriteResult wr)> callback_;

[wtc, 2014/06/20 21:40:50]

Change "wr" to "result". But we should be able to use the WriteCallback typedef:

  WriteCallback callback_;

[dmziegler, 2014/06/23 18:31:24]

Done.

   bool write_blocked_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicServerPacketWriter);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_SERVER_PACKET_WRITER_H_