Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: net/quic/quic_connection_packet_writer_wrapper.h

Issue 340433002: Port QuicServer to Chrome network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address further comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_DEFAULT_PACKET_WRITER_H_ 5 #ifndef NET_QUIC_QUIC_CONNECTION_PACKET_WRITER_WRAPPER_H_
6 #define NET_QUIC_QUIC_DEFAULT_PACKET_WRITER_H_ 6 #define NET_QUIC_QUIC_CONNECTION_PACKET_WRITER_WRAPPER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "net/base/ip_endpoint.h" 10 #include "net/base/ip_endpoint.h"
11 #include "net/quic/quic_connection.h" 11 #include "net/quic/quic_connection.h"
12 #include "net/quic/quic_packet_writer.h" 12 #include "net/quic/quic_packet_writer.h"
13 #include "net/quic/quic_protocol.h" 13 #include "net/quic/quic_protocol.h"
14 #include "net/udp/datagram_client_socket.h" 14 #include "net/quic/quic_types.h"
15 #include "net/udp/udp_server_socket.h"
wtc 2014/06/20 21:40:48 Delete this header. This file is not using UDPServ
dmziegler 2014/06/23 18:31:23 Done.
15 16
16 namespace net { 17 namespace net {
17 18
18 struct WriteResult; 19 class QuicBlockedWriterInterface;
wtc 2014/06/20 21:40:48 Delete this unused forward declaration.
dmziegler 2014/06/23 18:31:23 Done.
20 class QuicServerPacketWriter;
19 21
20 // Chrome specific packet writer which uses a DatagramClientSocket for writing 22 // A wrapper packet writer that notifies a particular connection after its
21 // data. 23 // writes to the shared server packet writer finish.
22 class NET_EXPORT_PRIVATE QuicDefaultPacketWriter : public QuicPacketWriter { 24 // TODO(dmz) Try to merge with Chrome's default packet writer
25 class QuicConnectionPacketWriterWrapper : public QuicPacketWriter {
wtc 2014/06/20 21:40:48 Why isn't this class named QuicServerPacketWriterW
dmziegler 2014/06/23 18:31:23 I've renamed to QuicPerConnectionPacketWriter (and
23 public: 26 public:
24 QuicDefaultPacketWriter(); 27 QuicConnectionPacketWriterWrapper(QuicServerPacketWriter* writer,
25 explicit QuicDefaultPacketWriter(DatagramClientSocket* socket); 28 QuicConnection* connection);
26 virtual ~QuicDefaultPacketWriter(); 29 virtual ~QuicConnectionPacketWriterWrapper();
27 30
28 // QuicPacketWriter 31 // QuicPacketWriter
29 virtual WriteResult WritePacket(const char* buffer, 32 virtual WriteResult WritePacket(const char* buffer,
30 size_t buf_len, 33 size_t buf_len,
31 const IPAddressNumber& self_address, 34 const IPAddressNumber& self_address,
32 const IPEndPoint& peer_address) OVERRIDE; 35 const IPEndPoint& peer_address) OVERRIDE;
33 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE; 36 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;
34 virtual bool IsWriteBlocked() const OVERRIDE; 37 virtual bool IsWriteBlocked() const OVERRIDE;
35 virtual void SetWritable() OVERRIDE; 38 virtual void SetWritable() OVERRIDE;
36 39
37 void OnWriteComplete(int rv); 40 private:
38 void SetConnection(QuicConnection* connection) { 41 void OnWriteComplete(WriteResult wr);
wtc 2014/06/20 21:40:48 Name this parameter "result". Our Style Guide reco
dmziegler 2014/06/23 18:31:23 Done.
39 connection_ = connection;
40 }
41 42
42 protected: 43 base::WeakPtrFactory<QuicConnectionPacketWriterWrapper> weak_factory_;
43 void set_write_blocked(bool is_blocked) { 44 QuicServerPacketWriter* writer_; // Not owned.
wtc 2014/06/20 21:40:48 Our Style Guide recommends at least two spaces bef
dmziegler 2014/06/23 18:31:23 Done.
44 write_blocked_ = is_blocked; 45 QuicConnection* connection_;
45 }
46 46
47 private: 47 DISALLOW_COPY_AND_ASSIGN(QuicConnectionPacketWriterWrapper);
48 base::WeakPtrFactory<QuicDefaultPacketWriter> weak_factory_;
49 DatagramClientSocket* socket_;
50 QuicConnection* connection_;
51 bool write_blocked_;
52
53 DISALLOW_COPY_AND_ASSIGN(QuicDefaultPacketWriter);
54 }; 48 };
55 49
56 } // namespace net 50 } // namespace net
57 51
58 #endif // NET_QUIC_QUIC_DEFAULT_PACKET_WRITER_H_ 52 #endif // NET_QUIC_QUIC_CONNECTION_PACKET_WRITER_WRAPPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698