Fixes content_browsertests with --enable-text-input-focus-manager flag enabled.

Fixes content_browsertests with --enable-text-input-focus-manager flag enabled.

Some tests in content_browsertests are broken if --enable-text-input-focus-manager is enabled.  Fix those tests.

Since not all unittests run wm::FocusController::SetFocusedWindow, it turned out that we need WMTestHelper (instead of FocusController) to clear the text input client.

BUG=290701
TEST=Run content_browsertests with --enable-text-input-focus-manager enabled.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278793

[Yuki, 2014-06-19 16:36:56]

Could you guys review this CL?

piman@:
    content/
    The changes are very simple and trivial, I think.

sky@:
    ui/wm/test/

[sky, 2014-06-19 20:14:07]

https://codereview.chromium.org/340413002/diff/20001/content/public/test/cont...
File content/public/test/content_browser_test.cc (left):

https://codereview.chromium.org/340413002/diff/20001/content/public/test/cont...
content/public/test/content_browser_test.cc:107: #if !defined(OS_CHROMEOS) &&
defined(USE_AURA) && defined(USE_X11)
Can you investigate who added the USE_X11 bits here. I believe your change means
this code is now compiled for the ozone target, and I'm not sure that is
desirable.

https://codereview.chromium.org/340413002/diff/20001/ui/wm/test/wm_test_helpe...
File ui/wm/test/wm_test_helper.cc (right):

https://codereview.chromium.org/340413002/diff/20001/ui/wm/test/wm_test_helpe...
ui/wm/test/wm_test_helper.cc:20:
ui::TextInputFocusManager::GetInstance()->FocusTextInputClient(NULL);
Do you need to update any gyp dependencies?

[Yuki, 2014-06-20 01:30:51]

https://codereview.chromium.org/340413002/diff/20001/content/public/test/cont...
File content/public/test/content_browser_test.cc (left):

https://codereview.chromium.org/340413002/diff/20001/content/public/test/cont...
content/public/test/content_browser_test.cc:107: #if !defined(OS_CHROMEOS) &&
defined(USE_AURA) && defined(USE_X11)
On 2014/06/19 20:14:06, sky wrote:
> Can you investigate who added the USE_X11 bits here. I believe your change
means
> this code is now compiled for the ozone target, and I'm not sure that is
> desirable.

Please see line 94 and 107 at
http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/content_b...

I wrote this line first, and later sadrul@ changed so that ozone calls
ui::InitializeInputMethodForTesting, too, but he forgot to change this line.

https://codereview.chromium.org/340413002/diff/20001/ui/wm/test/wm_test_helpe...
File ui/wm/test/wm_test_helper.cc (right):

https://codereview.chromium.org/340413002/diff/20001/ui/wm/test/wm_test_helpe...
ui/wm/test/wm_test_helper.cc:20:
ui::TextInputFocusManager::GetInstance()->FocusTextInputClient(NULL);
On 2014/06/19 20:14:06, sky wrote:
> Do you need to update any gyp dependencies?

Yes, you're right.  I've added a dependency to ui_base.

[sky, 2014-06-20 14:53:39]

LGTM

[Yuki, 2014-06-20 17:16:11]

piman, could you review this CL as an owner of content/ ?

[piman, 2014-06-20 17:18:54]

lgtm

[Yuki, 2014-06-20 17:26:48]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-06-20 17:31:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yukishiino@chromium.org/340413002/2

[commit-bot: I haz the power, 2014-06-20 18:16:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-20 19:18:15]

Change committed as 278793