Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ThemePrefTest.java

Issue 340403004: Java wrapper for DistilledPagePrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Formatting changes, added test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ThemePrefTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ThemePrefTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ThemePrefTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..e61e46c45f89af28e534d2fb7e5c384e0410c2d2
--- /dev/null
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ThemePrefTest.java
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.dom_distiller;
+
+import android.test.suitebuilder.annotation.SmallTest;
+
+import org.chromium.base.test.util.Feature;
+import org.chromium.base.ThreadUtils;
+import org.chromium.chrome.browser.profiles.Profile;
+import org.chromium.chrome.shell.ChromeShellTestBase;
+import org.chromium.components.dom_distiller.core.DistilledPagePrefs;
+import org.chromium.components.dom_distiller.core.DomDistillerService;
+import org.chromium.components.dom_distiller.core.Theme;
+
+/**
+ * Ensures that Distilled Page Theme Preferences are working
nyquist 2014/07/09 23:49:04 "Test class for {@link DistilledPagePrefs}."
sunangel 2014/07/10 14:31:52 Done.
+ */
+public class ThemePrefTest extends ChromeShellTestBase {
nyquist 2014/07/09 23:49:04 Rename this to DistilledPagePrefsTest
sunangel 2014/07/10 14:31:52 Done.
+ @SmallTest
+ @Feature({"ReaderMode"})
nyquist 2014/07/09 23:49:03 s/ReaderMode/DomDistiller/
sunangel 2014/07/10 14:31:52 Done.
+ public void testGetPrefs() throws InterruptedException {
+ startChromeBrowserProcessSync(getInstrumentation().getTargetContext());
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
nyquist 2014/07/09 23:49:04 Annotate this test with @UiThreadTest instead.
sunangel 2014/07/10 14:31:52 I think I did this...not sure if I did it right.
+ @Override
+ public void run() {
+ DomDistillerService service = DomDistillerServiceFactory.
+ getForProfile(Profile.getLastUsedProfile());
+ DistilledPagePrefs mDistilledPagePrefs =
nyquist 2014/07/09 23:49:04 m-prefix is only for member fields. Either remove
sunangel 2014/07/10 14:31:52 Done.
+ mDistilledPagePrefs = service.getDistilledPagePrefs();
+ assertNotNull(service);
nyquist 2014/07/09 23:49:04 This should come before you use it, so move up to
sunangel 2014/07/10 14:31:52 Done.
+ assertNotNull(mDistilledPagePrefs);
+ //Check default theme
nyquist 2014/07/09 23:49:03 Add space after // and add a period at the end of
sunangel 2014/07/10 14:31:52 Done.
+ assertEquals(mDistilledPagePrefs.getTheme(), Theme.LIGHT);
+ //Check that theme can be correctly set
+ mDistilledPagePrefs.setTheme(Theme.DARK);
+ assertEquals(mDistilledPagePrefs.getTheme(), Theme.DARK);
+ mDistilledPagePrefs.setTheme(Theme.LIGHT);
+ assertEquals(mDistilledPagePrefs.getTheme(), Theme.LIGHT);
+ mDistilledPagePrefs.setTheme(Theme.SEPIA);
+ assertEquals(mDistilledPagePrefs.getTheme(), Theme.SEPIA);
+ }
+ });
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698