Java wrapper for DistilledPagePrefs.

components/dom_distiller/core/dom_distiller_service_android.cc

Index: components/dom_distiller/core/dom_distiller_service_android.cc
diff --git a/components/dom_distiller/core/dom_distiller_service_android.cc b/components/dom_distiller/core/dom_distiller_service_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..563a31c51061bd70dbfb875e5ac73cc2c282faf5
--- /dev/null
+++ b/components/dom_distiller/core/dom_distiller_service_android.cc
@@ -0,0 +1,37 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/dom_distiller/core/dom_distiller_service.h"
+#include "components/dom_distiller/core/dom_distiller_service_android.h"
+#include "components/dom_distiller/core/reader_mode_preferences.h"
+
+#include "jni/DomDistillerService_jni.h"
+
+DomDistillerServiceAndroid::DomDistillerServiceAndroid(

[nyquist, 2014/06/30 20:33:23]

This constructor can call a private static create method on the Java object,
passing in |this|. This would call a private constructor passing in the pointer
to |this|.

[sunangel, 2014/07/07 21:21:29]

Done.

+    JNIEnv* env,
+    jobject obj,
+    dom_distiller::DomDistillerService* ptr) {

[nyquist, 2014/06/30 20:33:23]

Nit: service

[sunangel, 2014/07/07 21:21:29]

Done.

+  service_ = ptr;

[nyquist, 2014/06/30 20:33:23]

How about you call a static create method here on the Java object?

[sunangel, 2014/07/07 21:21:29]

Done.

+}
+
+jlong Init(JNIEnv* env, jobject obj, jlong servicePtr) {

[nyquist, 2014/06/30 20:33:23]

I think we can turn this around and you could instead call a static
create-method from the constructor.

[sunangel, 2014/07/07 21:21:29]

Done.

+  dom_distiller::DomDistillerService* s =

[nyquist, 2014/06/30 20:33:23]

|service|

[sunangel, 2014/07/07 21:21:30]

Done.

+      reinterpret_cast<dom_distiller::DomDistillerService*>(servicePtr);
+  DomDistillerServiceAndroid* dom_distiller_service_android =
+      new DomDistillerServiceAndroid(env, obj, s);
+  return reinterpret_cast<intptr_t>(dom_distiller_service_android);
+}
+
+/**
+ * Returns native pointer to native reader mode preferences registered with
+ * dom_distiller_service.
+ */
+jlong DomDistillerServiceAndroid::GetReaderModePrefsPointer(JNIEnv* env,

[nyquist, 2014/06/30 20:33:23]

This can instead return the jobject DistilledPagePrefs

[sunangel, 2014/07/07 21:21:29]

not doing this as per conversation
On 2014/06/30 20:33:23, nyquist wrote:

+                                                            jobject obj) {
+  return reinterpret_cast<intptr_t>(service_->GetReaderModePrefs());
+}
+
+bool DomDistillerServiceAndroid::Register(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}