components/dom_distiller/core/theme_list.h - Issue 340403004: Java wrapper for DistilledPagePrefs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/core/theme_list.h

Issue 340403004: Java wrapper for DistilledPagePrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: spacing, fixed theme_list Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards, it's included

	6 // inside a macro to generate enum values.

	7

	8 #ifndef DEFINE_THEME

	9 #error "DEFINE_THEME should be defined before including this file"

	10 #endif

	11 // First argument represents native enum, second argument represents Java enum,
	nyquist 2014/07/11 00:19:02 This comment should be updated. This comment should be updated. sunangel 2014/07/11 15:47:48 Done. Show quoted text On 2014/07/11 00:19:02, nyquist wrote: > This comment should be updated. Done.
	12 // third argument represents value corresponding to the names in the enum

	13 DEFINE_THEME(LIGHT, 0)
	nyquist 2014/07/11 00:19:02 Please update components/dom_distiller/core/distil Please update components/dom_distiller/core/distilled_page_prefs.h sunangel 2014/07/11 15:47:48 Done. Show quoted text On 2014/07/11 00:19:02, nyquist wrote: > Please update components/dom_distiller/core/distilled_page_prefs.h Done.
	14 DEFINE_THEME(DARK, 1)

	15 DEFINE_THEME(SEPIA, 2)
	nyquist 2014/07/11 00:19:02 I think this is missing THEME_COUNT I think this is missing THEME_COUNT sunangel 2014/07/11 15:47:48 Done. Show quoted text On 2014/07/11 00:19:02, nyquist wrote: > I think this is missing THEME_COUNT Done.
OLD	NEW