components/dom_distiller/core/theme_list.h - Issue 340403004: Java wrapper for DistilledPagePrefs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/core/theme_list.h

Issue 340403004: Java wrapper for DistilledPagePrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: namespaces to classes, native init, enum Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file intentionally does not have header guards, it's included	5 // This file intentionally does not have header guards, it's included

6 // inside a macro to generate enum values.	6 // inside a macro to generate enum values.

7 #ifndef DEFINE_REQUEST_PRIORITY	7

8 #error "DEFINE_REQUEST_PRIORITY should be defined before including this file"	8 #ifndef DEFINE_THEME

	9 #error "DEFINE_THEME should be defined before including this file"

9 #endif	10 #endif

10 DEFINE_REQUEST_PRIORITY(IDLE, 0)	11
	nyquist 2014/07/08 01:02:35 Could you add a comment here that explains what th Could you add a comment here that explains what the three different arguments are? sunangel 2014/07/08 20:41:00 Done. Show quoted text On 2014/07/08 01:02:35, nyquist wrote: > Could you add a comment here that explains what the three different arguments > are? Done.
11 DEFINE_REQUEST_PRIORITY(LOWEST, 1)	12 DEFINE_THEME(kLight, LIGHT, 0)

12 DEFINE_REQUEST_PRIORITY(LOW, 2)	13 DEFINE_THEME(kDark, DARK, 1)

13 DEFINE_REQUEST_PRIORITY(MEDIUM, 3)	14 DEFINE_THEME(kSepia, SEPIA, 2)

14 DEFINE_REQUEST_PRIORITY(HIGHEST, 4)

OLD	NEW