components/dom_distiller/core/distilled_page_prefs_android.h - Issue 340403004: Java wrapper for DistilledPagePrefs.

Side by Side Diff: components/dom_distiller/core/distilled_page_prefs_android.h

Issue 340403004: Java wrapper for DistilledPagePrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: namespaces to classes, native init, enum Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/dom_distiller/core/distilled_page_prefs.h ('K') | « components/dom_distiller/core/distilled_page_prefs.h ('k') | components/dom_distiller/core/distilled_page_prefs_android.cc » ('j') | components/dom_distiller/core/distilled_page_prefs_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_DOM_DISTILLER_CORE_DISTILLED_PAGE_PREFS_ANDROID_H_

	6 #define COMPONENTS_DOM_DISTILLER_CORE_DISTILLED_PAGE_PREFS_ANDROID_H_

	7

	8 #include <jni.h>

	9

	10 #include "base/android/scoped_java_ref.h"

	11 #include "components/dom_distiller/core/distilled_page_prefs.h"

	12
	nyquist 2014/07/08 01:02:34 remove empty line. remove empty line. sunangel 2014/07/08 20:40:59 Done. Show quoted text On 2014/07/08 01:02:34, nyquist wrote: > remove empty line. Done.
	13

	14 class DistilledPagePrefsAndroid{
	nyquist 2014/07/08 01:02:34 add namespace dom_distiller and android and remove add namespace dom_distiller and android and remove "dom_distiller::" in the places below. Also, missing whitespace before { sunangel 2014/07/08 20:40:59 Done. Show quoted text On 2014/07/08 01:02:34, nyquist wrote: > add namespace dom_distiller and android and remove "dom_distiller::" in the > places below. Also, missing whitespace before { Done.
	15
	nyquist 2014/07/08 01:02:34 remove empty line remove empty line sunangel 2014/07/08 20:40:59 Done. Show quoted text On 2014/07/08 01:02:34, nyquist wrote: > remove empty line Done.
	16 public:

	17 DistilledPagePrefsAndroid(JNIEnv* env, jobject obj,

	18 dom_distiller::DistilledPagePrefs* d);
	nyquist 2014/07/08 01:02:34 Rename \|d\| to something clearer. Rename \|d\| to something clearer. sunangel 2014/07/08 20:40:59 Done. Show quoted text On 2014/07/08 01:02:34, nyquist wrote: > Rename \|d\| to something clearer. Done.
	19 static bool Register(JNIEnv* env);

	20 void SetTheme(JNIEnv* env, jobject obj, jint color_mode);
	nyquist 2014/07/08 01:02:34 rename color_mode to theme. rename color_mode to theme. sunangel 2014/07/08 20:41:00 Done. Show quoted text On 2014/07/08 01:02:34, nyquist wrote: > rename color_mode to theme. Done.
	21 virtual ~DistilledPagePrefsAndroid();
	nyquist 2014/07/08 01:02:34 Put the destructor after the destructor. See decla Put the destructor after the destructor. See declaration ordering at: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar... sunangel 2014/07/08 20:40:59 Done. Show quoted text On 2014/07/08 01:02:34, nyquist wrote: > Put the destructor after the destructor. See declaration ordering at: > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar... Done.
	22

	23 private:

	24 dom_distiller::DistilledPagePrefs* distilled_page_prefs_;

	25
	nyquist 2014/07/08 01:02:34 add DISALLOW_COPY_AND_ASSIGN add DISALLOW_COPY_AND_ASSIGN sunangel 2014/07/08 20:40:59 Done. Show quoted text On 2014/07/08 01:02:34, nyquist wrote: > add DISALLOW_COPY_AND_ASSIGN Done.
	26 };

	27

	28 #endif // COMPONENTS_DOM_DISTILLER_CORE_DISTILLED_PAGE_PREFS_ANDROID_H_

OLD	NEW