components/dom_distiller/core/dom_distiller_service_android.h - Issue 340403004: Java wrapper for DistilledPagePrefs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/core/dom_distiller_service_android.h

Issue 340403004: Java wrapper for DistilledPagePrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Spacing and indentation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/dom_distiller/android/java/src/org/chromium/components/dom_distiller/core/ReaderModePreferencesAndroid.java ('K') | « components/dom_distiller/android/java/src/org/chromium/components/dom_distiller/core/ReaderModePreferencesAndroid.java ('k') | components/dom_distiller/core/dom_distiller_service_android.cc » ('j') | components/dom_distiller/core/dom_distiller_service_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H_

	6 #define COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H_

	7

	8 #include <jni.h>

	9 #include "components/dom_distiller/core/dom_distiller_service.h"

	10

	11 class DomDistillerServiceAndroid {
	nyquist 2014/06/30 20:33:23 Put in namespaces dom_distiller and android Put in namespaces dom_distiller and android sunangel 2014/07/07 21:21:30 Done. Show quoted text On 2014/06/30 20:33:23, nyquist wrote: > Put in namespaces dom_distiller and android Done.
	12 public:

	13 DomDistillerServiceAndroid(JNIEnv* env,

	14 jobject obj,

	15 dom_distiller::DomDistillerService* d);

	16 static bool Register(JNIEnv* env);

	17 jlong GetReaderModePrefsPointer(JNIEnv* env, jobject obj);
	nyquist 2014/06/30 20:33:23 Private? Private? sunangel 2014/07/07 21:21:30 If I make it private, DomDistillerService seems to If I make it private, DomDistillerService seems to not be able to call it either...unless I make DomDistillerService a friend too...do you have a preference? On 2014/06/30 20:33:23, nyquist wrote: Show quoted text > Private?
	18

	19 private:
	nyquist 2014/06/30 20:33:23 Add a new method to access the Java object. This c Add a new method to access the Java object. This could be private. Also, add the DomDistillerServiceFactoryAndroid class as a forward declared friend. sunangel 2014/07/07 21:21:30 second part done..first part not done as per conve second part done..first part not done as per conversation On 2014/06/30 20:33:23, nyquist wrote: Show quoted text > Add a new method to access the Java object. This could be private. > Also, add the DomDistillerServiceFactoryAndroid class as a forward declared > friend.
	20 dom_distiller::DomDistillerService* service_;

	21 };

	22

	23 #endif // COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_SERVICE_ANDROID_H

OLD	NEW