Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: Source/modules/crypto/CryptoKey.h

Issue 340353006: [webcrypto] Replace KeyAlgorithm interfaces with an Object. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase onto master Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/crypto/CryptoKey.h
diff --git a/Source/modules/crypto/CryptoKey.h b/Source/modules/crypto/CryptoKey.h
index a7410d9b037a552fe7df8c5624133a5d49fbb5f7..06623abca07d626e6a469eb9dc7b6190500bd3a9 100644
--- a/Source/modules/crypto/CryptoKey.h
+++ b/Source/modules/crypto/CryptoKey.h
@@ -33,7 +33,6 @@
#include "bindings/v8/ScriptWrappable.h"
#include "modules/crypto/NormalizeAlgorithm.h"
-#include "platform/heap/Handle.h"
sof 2014/06/26 19:56:51 It'd be good if you could leave this in.
eroman 2014/06/27 21:52:19 Done. However what is the motivation for doing so,
sof 2014/06/28 06:03:35 The class derives from GarbageCollectedFinalized<>
eroman 2014/06/30 19:57:59 Ah thanks for pointing that out!
#include "public/platform/WebCryptoAlgorithm.h"
#include "public/platform/WebCryptoKey.h"
#include "wtf/Forward.h"
@@ -56,7 +55,6 @@ public:
String type() const;
bool extractable() const;
- KeyAlgorithm* algorithm();
Vector<String> usages() const;
const blink::WebCryptoKey& key() const { return m_key; }
@@ -69,13 +67,12 @@ public:
static bool parseFormat(const String&, blink::WebCryptoKeyFormat&, CryptoResult*);
static bool parseUsageMask(const Vector<String>&, blink::WebCryptoKeyUsageMask&, CryptoResult*);
- void trace(Visitor*);
+ void trace(Visitor*) { }
protected:
explicit CryptoKey(const blink::WebCryptoKey&);
const blink::WebCryptoKey m_key;
- Member<KeyAlgorithm> m_algorithm;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698