Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: Source/modules/crypto/CryptoKey.cpp

Issue 340353006: [webcrypto] Replace KeyAlgorithm interfaces with an Object. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove const reference and make v8value a value Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/crypto/CryptoKey.h ('k') | Source/modules/crypto/CryptoKey.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/crypto/CryptoKey.cpp
diff --git a/Source/modules/crypto/CryptoKey.cpp b/Source/modules/crypto/CryptoKey.cpp
index 9a659284c94765fcc0253da1d525c77bcd848f9e..b433090b759ecd16474e7d7572fa7a37a9bbfc50 100644
--- a/Source/modules/crypto/CryptoKey.cpp
+++ b/Source/modules/crypto/CryptoKey.cpp
@@ -33,9 +33,9 @@
#include "bindings/core/v8/ExceptionState.h"
#include "core/dom/ExceptionCode.h"
-#include "modules/crypto/KeyAlgorithm.h"
#include "platform/CryptoResult.h"
#include "public/platform/WebCryptoAlgorithmParams.h"
+#include "public/platform/WebCryptoKeyAlgorithm.h"
#include "public/platform/WebString.h"
namespace WebCore {
@@ -147,13 +147,6 @@ bool CryptoKey::extractable() const
return m_key.extractable();
}
-KeyAlgorithm* CryptoKey::algorithm()
-{
- if (!m_algorithm)
- m_algorithm = KeyAlgorithm::create(m_key.algorithm());
- return m_algorithm.get();
-}
-
// FIXME: This creates a new javascript array each time. What should happen
// instead is return the same (immutable) array. (Javascript callers can
// distinguish this by doing an == test on the arrays and seeing they are
@@ -222,9 +215,4 @@ bool CryptoKey::parseUsageMask(const Vector<String>& usages, blink::WebCryptoKey
return true;
}
-void CryptoKey::trace(Visitor* visitor)
-{
- visitor->trace(m_algorithm);
-}
-
} // namespace WebCore
« no previous file with comments | « Source/modules/crypto/CryptoKey.h ('k') | Source/modules/crypto/CryptoKey.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698