Issue 340303002: Fix breakage on official builers by NPAPI removal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340303002: Fix breakage on official builers by NPAPI removal (Closed)

Created:
6 years, 6 months ago by Sergey Ulanov

Modified:
6 years, 6 months ago

Reviewers:
weitao, Wez

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix breakage on official builers by NPAPI removal r278198 broke official build bots. This change should fix it. TBR=wez@chromium.org BUG=134215 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278204

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	remoting/remoting_host_linux.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

Committed patchset #1 manually as r278204 (tree was closed).

6 years, 6 months ago (2014-06-19 00:33:33 UTC) #2

weitao

Sergey, there are also references to the plugin in chrome/tools/build/[platform]/FILES.cfg. Could you please remove those ...

6 years, 6 months ago (2014-06-19 17:01:53 UTC) #4

Sergey Ulanov

6 years, 6 months ago (2014-06-19 18:17:49 UTC) #5

Message was sent while issue was closed.

On 2014/06/19 17:01:53, weitaosu wrote:
> Sergey, there are also references to the plugin in
> chrome/tools/build/[platform]/FILES.cfg. Could you please remove those as
> well?

https://codereview.chromium.org/338713003/

Expand Messages | Collapse Messages