Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 340273003: Rename innerTextElement/Value used in <input> and <textarea> to innerEditor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTextAreaElement.h ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextAreaElement.cpp
diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp
index 180a6179a9aca51901016d02ed60173ab57b625c..5b4fde76b34ffde7724ddf85a939202395347561 100644
--- a/Source/core/html/HTMLTextAreaElement.cpp
+++ b/Source/core/html/HTMLTextAreaElement.cpp
@@ -97,7 +97,7 @@ PassRefPtrWillBeRawPtr<HTMLTextAreaElement> HTMLTextAreaElement::create(Document
void HTMLTextAreaElement::didAddUserAgentShadowRoot(ShadowRoot& root)
{
- root.appendChild(TextControlInnerTextElement::create(document()));
+ root.appendChild(TextControlInnerEditorElement::create(document()));
}
const AtomicString& HTMLTextAreaElement::formControlType() const
@@ -121,7 +121,7 @@ void HTMLTextAreaElement::childrenChanged(bool changedByParser, Node* beforeChan
HTMLElement::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
setLastChangeWasNotUserEdit();
if (m_isDirty)
- setInnerTextValue(value());
+ setInnerEditorValue(value());
else
setNonDirtyValue(defaultValue());
}
@@ -290,7 +290,7 @@ void HTMLTextAreaElement::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*
return;
unsigned unsignedMaxLength = static_cast<unsigned>(signedMaxLength);
- const String& currentValue = innerTextValue();
+ const String& currentValue = innerEditorValue();
unsigned currentLength = computeLengthForSubmission(currentValue);
if (currentLength + computeLengthForSubmission(event->text()) < unsignedMaxLength)
return;
@@ -320,7 +320,7 @@ void HTMLTextAreaElement::updateValue() const
return;
ASSERT(renderer());
- m_value = innerTextValue();
+ m_value = innerEditorValue();
const_cast<HTMLTextAreaElement*>(this)->m_valueIsUpToDate = true;
const_cast<HTMLTextAreaElement*>(this)->notifyFormStateChanged();
m_isDirty = true;
@@ -364,7 +364,7 @@ void HTMLTextAreaElement::setValueCommon(const String& newValue, TextFieldEventB
return;
m_value = normalizedValue;
- setInnerTextValue(m_value);
+ setInnerEditorValue(m_value);
if (eventBehavior == DispatchNoEvent)
setLastChangeWasNotUserEdit();
updatePlaceholderVisibility(false);
@@ -387,9 +387,9 @@ void HTMLTextAreaElement::setValueCommon(const String& newValue, TextFieldEventB
}
}
-void HTMLTextAreaElement::setInnerTextValue(const String& value)
+void HTMLTextAreaElement::setInnerEditorValue(const String& value)
{
- HTMLTextFormControlElement::setInnerTextValue(value);
+ HTMLTextFormControlElement::setInnerEditorValue(value);
m_valueIsUpToDate = true;
}
@@ -456,9 +456,9 @@ void HTMLTextAreaElement::setSuggestedValue(const String& value)
m_suggestedValue = value;
if (!value.isNull())
- setInnerTextValue(m_suggestedValue);
+ setInnerEditorValue(m_suggestedValue);
else
- setInnerTextValue(m_value);
+ setInnerEditorValue(m_value);
updatePlaceholderVisibility(false);
setNeedsStyleRecalc(SubtreeStyleChange);
}
@@ -552,7 +552,7 @@ void HTMLTextAreaElement::updatePlaceholderText()
placeholder = newElement.get();
placeholder->setShadowPseudoId(AtomicString("-webkit-input-placeholder", AtomicString::ConstructFromLiteral));
placeholder->setAttribute(idAttr, ShadowElementNames::placeholder());
- userAgentShadowRoot()->insertBefore(placeholder, innerTextElement()->nextSibling());
+ userAgentShadowRoot()->insertBefore(placeholder, innerEditorElement()->nextSibling());
}
placeholder->setTextContent(placeholderText);
}
« no previous file with comments | « Source/core/html/HTMLTextAreaElement.h ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698