Issue 340273003: Rename innerTextElement/Value used in <input> and <textarea> to innerEditor.

Issue 340273003: Rename innerTextElement/Value used in <input> and <textarea> to innerEditor. (Closed)

Created:
6 years, 6 months ago by tkent

Modified:
6 years, 6 months ago

Reviewers:
Kunihiko Sakamoto

CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename innerTextElement/Value used in <input> and <textarea> to innerEditor. 'innerText' is super-confusing because we have Element::innerText and Element::setInnerText. BUG= TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176483

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -156 lines)			Patch
M	Source/core/editing/SpellChecker.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLTextAreaElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLTextAreaElement.cpp	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/html/HTMLTextFormControlElement.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLTextFormControlElement.cpp	View	11 chunks	+19 lines, -19 lines	0 comments	Download
M	Source/core/html/HTMLTextFormControlElementTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/NumberInputType.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/forms/SearchInputType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/TextFieldInputType.cpp	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/html/shadow/TextControlInnerElements.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/shadow/TextControlInnerElements.cpp	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/rendering/RenderTextControl.h	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	Source/core/rendering/RenderTextControl.cpp	View	7 chunks	+33 lines, -33 lines	0 comments	Download
M	Source/core/rendering/RenderTextControlMultiLine.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderTextControlMultiLine.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderTextControlSingleLine.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderTextControlSingleLine.cpp	View	11 chunks	+43 lines, -43 lines	0 comments	Download
M	Source/web/WebFormControlElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/340273003/20001

6 years, 6 months ago (2014-06-19 03:37:23 UTC) #4

Message was sent while issue was closed.

Change committed as 176483

Expand Messages | Collapse Messages