Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340273002: Add new test file for win8 trybots (Closed)

Created:
6 years, 6 months ago by sheyang
Modified:
6 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Sergey Berezin, Sergiy Byelozyorov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

add new test file for win8 trybots BUG=344543 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278343

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
A testing/buildbot/chromium_win8_trybot.json View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sheyang
6 years, 6 months ago (2014-06-18 23:49:45 UTC) #1
Paweł Hajdan Jr.
LGTM with a comment. https://codereview.chromium.org/340273002/diff/1/testing/buildbot/chromium_win8_trybot.json File testing/buildbot/chromium_win8_trybot.json (right): https://codereview.chromium.org/340273002/diff/1/testing/buildbot/chromium_win8_trybot.json#newcode11 testing/buildbot/chromium_win8_trybot.json:11: "events_unittests", nit: Remove the comma, ...
6 years, 6 months ago (2014-06-19 01:07:30 UTC) #2
sheyang
https://codereview.chromium.org/340273002/diff/1/testing/buildbot/chromium_win8_trybot.json File testing/buildbot/chromium_win8_trybot.json (right): https://codereview.chromium.org/340273002/diff/1/testing/buildbot/chromium_win8_trybot.json#newcode11 testing/buildbot/chromium_win8_trybot.json:11: "events_unittests", On 2014/06/19 01:07:30, Paweł Hajdan Jr. wrote: > ...
6 years, 6 months ago (2014-06-19 01:47:10 UTC) #3
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-19 01:47:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/340273002/20001
6 years, 6 months ago (2014-06-19 01:50:17 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 12:33:44 UTC) #6
Message was sent while issue was closed. 
Change committed as 278343

Powered by Google App Engine
This is Rietveld 408576698